* [PATCH v2] staging: wlan-ng: silence incorrect type in argument 1 (different address spaces)
@ 2021-05-01 11:39 Ashish Kalra
2021-05-01 12:23 ` Greg Kroah-Hartman
0 siblings, 1 reply; 8+ messages in thread
From: Ashish Kalra @ 2021-05-01 11:39 UTC (permalink / raw)
To: Greg Kroah-Hartman, Ashish Kalra, Ivan Safonov, Abheek Dhawan,
Andrew Morton, Waiman Long, Pritthijit Nath, Allen Pais,
linux-staging, linux-kernel
Currently p80211knetdev_do_ioctl use type casting to req->data to prevent sparse warning while calling memdup_user, instead of type casting it here, its better to change data type for data inside p80211ioctl_req to include __user.
Signed-off-by: Ashish Kalra <eashishkalra@gmail.com>
---
Changes from v1:
removed type casting of (void __user *) for req->data and corrected type for data to include __user.
drivers/staging/wlan-ng/p80211ioctl.h | 2 +-
drivers/staging/wlan-ng/p80211netdev.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wlan-ng/p80211ioctl.h b/drivers/staging/wlan-ng/p80211ioctl.h
index ed65ac57adbe..77e8d2913b76 100644
--- a/drivers/staging/wlan-ng/p80211ioctl.h
+++ b/drivers/staging/wlan-ng/p80211ioctl.h
@@ -81,7 +81,7 @@
struct p80211ioctl_req {
char name[WLAN_DEVNAMELEN_MAX];
- caddr_t data;
+ char __user *data;
u32 magic;
u16 len;
u32 result;
diff --git a/drivers/staging/wlan-ng/p80211netdev.c b/drivers/staging/wlan-ng/p80211netdev.c
index 70570e8a5ad2..dfb2d2832830 100644
--- a/drivers/staging/wlan-ng/p80211netdev.c
+++ b/drivers/staging/wlan-ng/p80211netdev.c
@@ -569,7 +569,7 @@ static int p80211knetdev_do_ioctl(struct net_device *dev,
goto bail;
}
- msgbuf = memdup_user((void __user *)req->data, req->len);
+ msgbuf = memdup_user(req->data, req->len);
if (IS_ERR(msgbuf)) {
result = PTR_ERR(msgbuf);
goto bail;
@@ -579,7 +579,7 @@ static int p80211knetdev_do_ioctl(struct net_device *dev,
if (result == 0) {
if (copy_to_user
- ((void __user *)req->data, msgbuf, req->len)) {
+ (req->data, msgbuf, req->len)) {
result = -EFAULT;
}
}
--
2.30.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2] staging: wlan-ng: silence incorrect type in argument 1 (different address spaces)
2021-05-01 11:39 [PATCH v2] staging: wlan-ng: silence incorrect type in argument 1 (different address spaces) Ashish Kalra
@ 2021-05-01 12:23 ` Greg Kroah-Hartman
2021-05-01 13:54 ` Ashish
0 siblings, 1 reply; 8+ messages in thread
From: Greg Kroah-Hartman @ 2021-05-01 12:23 UTC (permalink / raw)
To: Ashish Kalra
Cc: Ivan Safonov, Abheek Dhawan, Andrew Morton, Waiman Long,
Pritthijit Nath, Allen Pais, linux-staging, linux-kernel
On Sat, May 01, 2021 at 05:09:28PM +0530, Ashish Kalra wrote:
> Currently p80211knetdev_do_ioctl use type casting to req->data to prevent sparse warning while calling memdup_user, instead of type casting it here, its better to change data type for data inside p80211ioctl_req to include __user.
Please properly line-wrap your changelog comments.
Can you fix it up and resend it as v3?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] staging: wlan-ng: silence incorrect type in argument 1 (different address spaces)
2021-05-01 12:23 ` Greg Kroah-Hartman
@ 2021-05-01 13:54 ` Ashish
0 siblings, 0 replies; 8+ messages in thread
From: Ashish @ 2021-05-01 13:54 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Ashish Kalra, Ivan Safonov, Abheek Dhawan, Andrew Morton,
Waiman Long, Pritthijit Nath, Allen Pais, linux-staging,
linux-kernel
On Sat, May 01, 2021 at 02:23:12PM +0200, Greg Kroah-Hartman wrote:
> On Sat, May 01, 2021 at 05:09:28PM +0530, Ashish Kalra wrote:
> > Currently p80211knetdev_do_ioctl use type casting to req->data to prevent sparse warning while calling memdup_user, instead of type casting it here, its better to change data type for data inside p80211ioctl_req to include __user.
>
> Please properly line-wrap your changelog comments.
>
> Can you fix it up and resend it as v3?
>
> thanks,
>
> greg k-h
Thanks Greg for your feedback
Kindly ignore v3 and review v4, i have modified it as pe your feedback
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] staging: wlan-ng: silence incorrect type in argument 1 (different address spaces)
2021-04-27 16:58 Ashish Kalra
@ 2021-04-28 6:02 ` Greg Kroah-Hartman
2021-04-27 18:04 ` ashish
0 siblings, 1 reply; 8+ messages in thread
From: Greg Kroah-Hartman @ 2021-04-28 6:02 UTC (permalink / raw)
To: Ashish Kalra; +Cc: linux-staging, linux-kernel
On Tue, Apr 27, 2021 at 04:58:44PM +0000, Ashish Kalra wrote:
> Corrected data type for variable data adding __user to make it cleaner and silence the Sparse warning. This is version 2 of patch, version 1 can be found at https://lore.kernel.org/linux-staging/20210420090142.GA4086@ashish-NUC8i5BEH/
>
> Signed-off-by: Ashish Kalra <eashishkalra@gmail.com>
> ---
>
> Changes from v1: removed type casting of (void __user *) for req->data and corrected type for data to include __user
Did you send this twice?
And please wrap your changelog text and put proper information in it,
not references to previous patches.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] staging: wlan-ng: silence incorrect type in argument 1 (different address spaces)
2021-04-28 6:02 ` Greg Kroah-Hartman
@ 2021-04-27 18:04 ` ashish
0 siblings, 0 replies; 8+ messages in thread
From: ashish @ 2021-04-27 18:04 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Ashish Kalra, linux-staging, linux-kernel
On Wed, Apr 28, 2021 at 08:02:31AM +0200, Greg Kroah-Hartman wrote:
> On Tue, Apr 27, 2021 at 04:58:44PM +0000, Ashish Kalra wrote:
> > Corrected data type for variable data adding __user to make it cleaner and silence the Sparse warning. This is version 2 of patch, version 1 can be found at https://lore.kernel.org/linux-staging/20210420090142.GA4086@ashish-NUC8i5BEH/
> >
> > Signed-off-by: Ashish Kalra <eashishkalra@gmail.com>
> > ---
> >
> > Changes from v1: removed type casting of (void __user *) for req->data and corrected type for data to include __user
>
> Did you send this twice?
>
> And please wrap your changelog text and put proper information in it,
> not references to previous patches.
>
> thanks,
>
> greg k-h
Thanks Greg
Sorry for sending twice due to some issue in To list
I have corrected and send again as per your inputs
hopefully it will be ok now
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] staging: wlan-ng: silence incorrect type in argument 1 (different address spaces)
@ 2021-04-27 18:03 Ashish Kalra
0 siblings, 0 replies; 8+ messages in thread
From: Ashish Kalra @ 2021-04-27 18:03 UTC (permalink / raw)
To: Greg Kroah-Hartman, Ashish Kalra, linux-staging, linux-kernel
Currently p80211knetdev_do_ioctl use type casting to req->data to prevent sparse warning while
calling memdup_user, instead of type casting it here, its better to change data type for data
inside p80211ioctl_req to include __user.
Signed-off-by: Ashish Kalra <eashishkalra@gmail.com>
---
Changes from v1:
removed type casting of (void __user *) for req->data and corrected type for data to include __user.
drivers/staging/wlan-ng/p80211ioctl.h | 2 +-
drivers/staging/wlan-ng/p80211netdev.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wlan-ng/p80211ioctl.h b/drivers/staging/wlan-ng/p80211ioctl.h
index ed65ac57a..77e8d2913 100644
--- a/drivers/staging/wlan-ng/p80211ioctl.h
+++ b/drivers/staging/wlan-ng/p80211ioctl.h
@@ -81,7 +81,7 @@
struct p80211ioctl_req {
char name[WLAN_DEVNAMELEN_MAX];
- caddr_t data;
+ char __user *data;
u32 magic;
u16 len;
u32 result;
diff --git a/drivers/staging/wlan-ng/p80211netdev.c b/drivers/staging/wlan-ng/p80211netdev.c
index 70570e8a5..dfb2d2832 100644
--- a/drivers/staging/wlan-ng/p80211netdev.c
+++ b/drivers/staging/wlan-ng/p80211netdev.c
@@ -569,7 +569,7 @@ static int p80211knetdev_do_ioctl(struct net_device *dev,
goto bail;
}
- msgbuf = memdup_user((void __user *)req->data, req->len);
+ msgbuf = memdup_user(req->data, req->len);
if (IS_ERR(msgbuf)) {
result = PTR_ERR(msgbuf);
goto bail;
@@ -579,7 +579,7 @@ static int p80211knetdev_do_ioctl(struct net_device *dev,
if (result == 0) {
if (copy_to_user
- ((void __user *)req->data, msgbuf, req->len)) {
+ (req->data, msgbuf, req->len)) {
result = -EFAULT;
}
}
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2] staging: wlan-ng: silence incorrect type in argument 1 (different address spaces)
@ 2021-04-27 17:22 Ashish Kalra
0 siblings, 0 replies; 8+ messages in thread
From: Ashish Kalra @ 2021-04-27 17:22 UTC (permalink / raw)
To: Greg Kroah-Hartman, Abheek Dhawan, Johannes Weiner,
Romain Perier, Waiman Long, Allen Pais, Ivan Safonov,
linux-staging, linux-kernel
Corrected data type for variable data adding __user to make it cleaner and silence the Sparse warning. This is version 2 of patch, version 1 can be found at https://lore.kernel.org/linux-staging/20210420090142.GA4086@ashish-NUC8i5BEH/
Signed-off-by: Ashish Kalra <eashishkalra@gmail.com>
---
Changes from v1: removed type casting of (void __user *) for req->data and corrected type for data to include __user.
drivers/staging/wlan-ng/p80211ioctl.h | 2 +-
drivers/staging/wlan-ng/p80211netdev.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wlan-ng/p80211ioctl.h b/drivers/staging/wlan-ng/p80211ioctl.h
index ed65ac57a..77e8d2913 100644
--- a/drivers/staging/wlan-ng/p80211ioctl.h
+++ b/drivers/staging/wlan-ng/p80211ioctl.h
@@ -81,7 +81,7 @@
struct p80211ioctl_req {
char name[WLAN_DEVNAMELEN_MAX];
- caddr_t data;
+ char __user *data;
u32 magic;
u16 len;
u32 result;
diff --git a/drivers/staging/wlan-ng/p80211netdev.c b/drivers/staging/wlan-ng/p80211netdev.c
index 70570e8a5..dfb2d2832 100644
--- a/drivers/staging/wlan-ng/p80211netdev.c
+++ b/drivers/staging/wlan-ng/p80211netdev.c
@@ -569,7 +569,7 @@ static int p80211knetdev_do_ioctl(struct net_device *dev,
goto bail;
}
- msgbuf = memdup_user((void __user *)req->data, req->len);
+ msgbuf = memdup_user(req->data, req->len);
if (IS_ERR(msgbuf)) {
result = PTR_ERR(msgbuf);
goto bail;
@@ -579,7 +579,7 @@ static int p80211knetdev_do_ioctl(struct net_device *dev,
if (result == 0) {
if (copy_to_user
- ((void __user *)req->data, msgbuf, req->len)) {
+ (req->data, msgbuf, req->len)) {
result = -EFAULT;
}
}
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2] staging: wlan-ng: silence incorrect type in argument 1 (different address spaces)
@ 2021-04-27 16:58 Ashish Kalra
2021-04-28 6:02 ` Greg Kroah-Hartman
0 siblings, 1 reply; 8+ messages in thread
From: Ashish Kalra @ 2021-04-27 16:58 UTC (permalink / raw)
To: Greg Kroah-Hartman, Ashish Kalra, linux-staging, linux-kernel
Corrected data type for variable data adding __user to make it cleaner and silence the Sparse warning. This is version 2 of patch, version 1 can be found at https://lore.kernel.org/linux-staging/20210420090142.GA4086@ashish-NUC8i5BEH/
Signed-off-by: Ashish Kalra <eashishkalra@gmail.com>
---
Changes from v1: removed type casting of (void __user *) for req->data and corrected type for data to include __user
---
drivers/staging/wlan-ng/p80211ioctl.h | 2 +-
drivers/staging/wlan-ng/p80211netdev.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wlan-ng/p80211ioctl.h b/drivers/staging/wlan-ng/p80211ioctl.h
index ed65ac57a..77e8d2913 100644
--- a/drivers/staging/wlan-ng/p80211ioctl.h
+++ b/drivers/staging/wlan-ng/p80211ioctl.h
@@ -81,7 +81,7 @@
struct p80211ioctl_req {
char name[WLAN_DEVNAMELEN_MAX];
- caddr_t data;
+ char __user *data;
u32 magic;
u16 len;
u32 result;
diff --git a/drivers/staging/wlan-ng/p80211netdev.c b/drivers/staging/wlan-ng/p80211netdev.c
index 70570e8a5..dfb2d2832 100644
--- a/drivers/staging/wlan-ng/p80211netdev.c
+++ b/drivers/staging/wlan-ng/p80211netdev.c
@@ -569,7 +569,7 @@ static int p80211knetdev_do_ioctl(struct net_device *dev,
goto bail;
}
- msgbuf = memdup_user((void __user *)req->data, req->len);
+ msgbuf = memdup_user(req->data, req->len);
if (IS_ERR(msgbuf)) {
result = PTR_ERR(msgbuf);
goto bail;
@@ -579,7 +579,7 @@ static int p80211knetdev_do_ioctl(struct net_device *dev,
if (result == 0) {
if (copy_to_user
- ((void __user *)req->data, msgbuf, req->len)) {
+ (req->data, msgbuf, req->len)) {
result = -EFAULT;
}
}
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-05-01 13:56 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-01 11:39 [PATCH v2] staging: wlan-ng: silence incorrect type in argument 1 (different address spaces) Ashish Kalra
2021-05-01 12:23 ` Greg Kroah-Hartman
2021-05-01 13:54 ` Ashish
-- strict thread matches above, loose matches on Subject: below --
2021-04-27 18:03 Ashish Kalra
2021-04-27 17:22 Ashish Kalra
2021-04-27 16:58 Ashish Kalra
2021-04-28 6:02 ` Greg Kroah-Hartman
2021-04-27 18:04 ` ashish
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).