From: Peter Zijlstra <peterz@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: linux-tip-commits@vger.kernel.org,
Rik van Riel <riel@surriel.com>,
x86@kernel.org, Vincent Guittot <vincent.guittot@linaro.org>
Subject: Re: [tip: sched/core] sched,fair: skip newidle_balance if a wakeup is pending
Date: Thu, 22 Apr 2021 10:15:26 +0200 [thread overview]
Message-ID: <YIEwnnhG9bFkPqQs@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <161907696062.29796.108437696048031441.tip-bot2@tip-bot2>
On Thu, Apr 22, 2021 at 07:36:00AM -0000, tip-bot2 for Rik van Riel wrote:
> @@ -10684,7 +10693,12 @@ out:
> if (time_after(this_rq->next_balance, next_balance))
> this_rq->next_balance = next_balance;
>
> - if (pulled_task)
> + /*
> + * If we are no longer idle, do not let the time spent here pull
> + * down this_rq->avg_idle. That could lead to newidle_balance not
> + * doing enough work, and the CPU actually going idle.
> + */
> + if (pulled_task || this_rq->ttwu_pending)
> this_rq->idle_stamp = 0;
I've un-committed this patch, because vingu was reporting increased idle
time because of this hunk. I had mistakenly assumed that was sorted
with v3, sorry for not keeping better track of things.
(also, now that I look again, please also fix the Subject to have a
capital after the :)
next prev parent reply other threads:[~2021-04-22 8:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 16:07 [PATCH v3] sched,fair: skip newidle_balance if a wakeup is pending Rik van Riel
2021-04-21 17:27 ` Vincent Guittot
2021-04-22 8:37 ` Vincent Guittot
2021-04-22 16:47 ` Rik van Riel
2021-04-22 7:36 ` [tip: sched/core] " tip-bot2 for Rik van Riel
2021-04-22 8:15 ` Peter Zijlstra [this message]
2021-04-22 17:02 [PATCH v4] sched,fair: Skip " Rik van Riel
2021-05-12 10:28 ` [tip: sched/core] " tip-bot2 for Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIEwnnhG9bFkPqQs@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=riel@surriel.com \
--cc=vincent.guittot@linaro.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).