From: Mike Rapoport <rppt@kernel.org>
To: David Hildenbrand <david@redhat.com>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>,
linux-mm@kvack.org, akpm@linux-foundation.org,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC V2] mm: Enable generic pfn_valid() to handle early sections with memmap holes
Date: Thu, 22 Apr 2021 13:03:58 +0300 [thread overview]
Message-ID: <YIFKDm0FMARKvP9B@kernel.org> (raw)
In-Reply-To: <61523566-f302-1051-9565-b1e129c6cac0@redhat.com>
On Thu, Apr 22, 2021 at 11:48:58AM +0200, David Hildenbrand wrote:
> >
> > > IOW, avoiding having to adjust generic pfn_valid()/pfn_to_online_page() at
> > > all. Am i missing something or should that be possible?
> >
> > We are back again to the question "should arm64 free its memmap".
> > If the answer is no, we don't need arm64::pfn_valid() for SPARSEMEM at all.
> > If the answer is yes, Anshuman's patch is way better than a custom
> > pfn_valid().
>
> Well, I propose something in between: stop freeing with SPARSEMEM, continue
> freeing with FLATMEM.
I'm all for it.
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2021-04-22 10:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 6:18 [PATCH v3 0/4] arm64: drop pfn_valid_within() and simplify pfn_valid() Mike Rapoport
2021-04-22 6:18 ` [PATCH v3 1/4] include/linux/mmzone.h: add documentation for pfn_valid() Mike Rapoport
2021-04-22 6:19 ` [PATCH v3 2/4] memblock: update initialization of reserved pages Mike Rapoport
2021-04-22 6:19 ` [PATCH v3 3/4] arm64: decouple check whether pfn is in linear map from pfn_valid() Mike Rapoport
2021-04-22 8:57 ` David Hildenbrand
2021-04-22 6:19 ` [PATCH v3 4/4] arm64: drop pfn_valid_within() and simplify pfn_valid() Mike Rapoport
2021-04-22 7:50 ` [RFC V2] mm: Enable generic pfn_valid() to handle early sections with memmap holes Anshuman Khandual
2021-04-22 8:27 ` Mike Rapoport
2021-04-22 11:23 ` Anshuman Khandual
2021-04-22 12:19 ` Mike Rapoport
2021-04-22 9:03 ` David Hildenbrand
2021-04-22 9:42 ` Mike Rapoport
2021-04-22 9:48 ` David Hildenbrand
2021-04-22 10:03 ` Mike Rapoport [this message]
2021-04-22 9:59 ` Anshuman Khandual
2021-05-24 4:58 ` Anshuman Khandual
2021-05-24 6:52 ` Mike Rapoport
2021-05-25 6:00 ` Anshuman Khandual
2021-05-25 6:32 ` Mike Rapoport
2021-05-25 9:52 ` Anshuman Khandual
2021-05-25 10:03 ` Mike Rapoport
2021-05-25 10:04 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIFKDm0FMARKvP9B@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=david@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).