From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5C88C433B4 for ; Fri, 23 Apr 2021 10:02:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B06661425 for ; Fri, 23 Apr 2021 10:02:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241962AbhDWKCz (ORCPT ); Fri, 23 Apr 2021 06:02:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:43114 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241950AbhDWKCy (ORCPT ); Fri, 23 Apr 2021 06:02:54 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 46FEC613D5; Fri, 23 Apr 2021 10:02:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619172138; bh=Atm2RSl1zOSBf0w7r+F7tka/tiajyaeJj79Yy8aLB/k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=v08p5z18mC1EQgkwvifjSGk6rfEegumTbZ44n7NkRVeIeif+Nc/4hv6ayxsGctcyu 7U+oQNRwisV1ocW+YtUMAmBbeeafWQ8aC45cgJBHAIFZURSRAceqXyvH2bMkQinXLj WC84wMrxpsicXq49c0KFpQPE8Xm/BqvQ/vWZBF1k= Date: Fri, 23 Apr 2021 12:02:15 +0200 From: Greg Kroah-Hartman To: Tao Zhang Cc: Mathieu Poirier , Suzuki K Poulose , Alexander Shishkin , Mike Leach , Leo Yan , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Tingwei Zhang , Mao Jinlong , Yuanfang Zhang Subject: Re: [PATCH v1] coresight: add node to reset all coresight devices Message-ID: References: <1619166578-28690-1-git-send-email-taozha@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1619166578-28690-1-git-send-email-taozha@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 23, 2021 at 04:29:38PM +0800, Tao Zhang wrote: > Add new reset_source_sink node to be able to disable all active > coresight devices. > In this way, we no longer need to manually disable all active > coresight devices one by one. After enabling multiple coresight > paths, users can reset their status more conveniently by this > node. > > This patch base on coresight-next repo > http://git.linaro.org/kernel/coresight.git/log/?h=next > > And this patch depends on the following patch > https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2551216.html > > Signed-off-by: Tingwei Zhang > Signed-off-by: Mao Jinlong > Signed-off-by: Tao Zhang > --- > drivers/hwtracing/coresight/coresight-core.c | 72 ++++++++++++++++++++++++---- > 1 file changed, 64 insertions(+), 8 deletions(-) You added new sysfs files with no new Documentation/ABI entries, so we have no idea how to review this code to determine if it does what you want it to do :( thanks, greg k-h