From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3794C433B4 for ; Fri, 23 Apr 2021 13:41:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9588361077 for ; Fri, 23 Apr 2021 13:41:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235502AbhDWNmG convert rfc822-to-8bit (ORCPT ); Fri, 23 Apr 2021 09:42:06 -0400 Received: from us-smtp-delivery-44.mimecast.com ([205.139.111.44]:43457 "EHLO us-smtp-delivery-44.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229965AbhDWNmB (ORCPT ); Fri, 23 Apr 2021 09:42:01 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-350-8QsdtI__OD24co9640BgGw-1; Fri, 23 Apr 2021 09:41:22 -0400 X-MC-Unique: 8QsdtI__OD24co9640BgGw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8DA4819253C2; Fri, 23 Apr 2021 13:41:21 +0000 (UTC) Received: from hog (unknown [10.40.192.89]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A30BB60BE5; Fri, 23 Apr 2021 13:41:19 +0000 (UTC) Date: Fri, 23 Apr 2021 15:41:17 +0200 From: Sabrina Dubroca To: Phillip Potter Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, edumazet@google.com, fw@strlen.de Subject: Re: [PATCH v2] net: geneve: modify IP header check in geneve6_xmit_skb and geneve_xmit_skb Message-ID: References: <20210422234945.1190-1-phil@philpotter.co.uk> MIME-Version: 1.0 In-Reply-To: <20210422234945.1190-1-phil@philpotter.co.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=sd@queasysnail.net X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: queasysnail.net Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2021-04-23, 00:49:45 +0100, Phillip Potter wrote: > Modify the header size check in geneve6_xmit_skb and geneve_xmit_skb > to use pskb_inet_may_pull rather than pskb_network_may_pull. This fixes > two kernel selftest failures introduced by the commit introducing the > checks: > IPv4 over geneve6: PMTU exceptions > IPv4 over geneve6: PMTU exceptions - nexthop objects > > It does this by correctly accounting for the fact that IPv4 packets may > transit over geneve IPv6 tunnels (and vice versa), and still fixes the > uninit-value bug fixed by the original commit. > > Reported-by: kernel test robot > Fixes: 6628ddfec758 ("net: geneve: check skb is large enough for IPv4/IPv6 header") > Suggested-by: Sabrina Dubroca > Signed-off-by: Phillip Potter > --- > > V2: > * Incorporated feedback from Sabrina Dubroca regarding pskb_inet_may_pull > * Added Fixes: tag as requested by Eric Dumazet Thanks Phillip. Acked-by: Sabrina Dubroca Jakub/David, it would be great if this could get in 5.12, otherwise geneve is a bit broken: https://bugzilla.kernel.org/show_bug.cgi?id=212749 -- Sabrina