From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09870C433B4 for ; Sat, 24 Apr 2021 15:55:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF351613DE for ; Sat, 24 Apr 2021 15:55:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236036AbhDXPzh (ORCPT ); Sat, 24 Apr 2021 11:55:37 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:39370 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230010AbhDXPz1 (ORCPT ); Sat, 24 Apr 2021 11:55:27 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1laKcF-000pnO-Nd; Sat, 24 Apr 2021 17:54:43 +0200 Date: Sat, 24 Apr 2021 17:54:43 +0200 From: Andrew Lunn To: Oleksij Rempel Cc: Woojung Huh , UNGLinuxDriver@microchip.com, Florian Fainelli , Vivien Didelot , Vladimir Oltean , "David S. Miller" , Jakub Kicinski , Michael Grzeschik , kernel@pengutronix.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Russell King Subject: Re: [PATCH net-next v6 05/10] net: dsa: microchip: Add Microchip KSZ8863 SPI based driver support Message-ID: References: <20210423080218.26526-1-o.rempel@pengutronix.de> <20210423080218.26526-6-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210423080218.26526-6-o.rempel@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > static int ksz8795_spi_probe(struct spi_device *spi) > { > + const struct regmap_config *regmap_config; > + struct device *ddev = &spi->dev; > + struct ksz8 *ksz8; > struct regmap_config rc; > struct ksz_device *dev; > - int i, ret; > + int i, ret = 0; More malformed trees. Once fixed, add my Reviewed-by: Andrew