From: Tomasz Duszynski <tomasz.duszynski@octakon.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Tomasz Duszynski <tomasz.duszynski@octakon.com>,
<linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<lars@metafoo.de>, <ardeleanalex@gmail.com>
Subject: Re: [PATCH v2] iio: core: fix ioctl handlers removal
Date: Sat, 24 Apr 2021 14:09:36 +0200 [thread overview]
Message-ID: <YIQKgLtdUlSHsJXu@arch> (raw)
In-Reply-To: <20210424115250.14d21a71@jic23-huawei>
On Sat, Apr 24, 2021 at 11:52:50AM +0100, Jonathan Cameron wrote:
> On Fri, 23 Apr 2021 10:02:44 +0200
> Tomasz Duszynski <tomasz.duszynski@octakon.com> wrote:
>
> > Currently ioctl handlers are removed twice. For the first time during
> > iio_device_unregister() then later on inside
> > iio_device_unregister_eventset() and iio_buffers_free_sysfs_and_mask().
> > Double free leads to kernel panic.
> >
> > Fix this by not touching ioctl handlers list directly but rather
> > letting code responsible for registration call the matching cleanup
> > routine itself.
> >
> > Fixes: 8dedcc3eee3ac ("iio: core: centralize ioctl() calls to the main chardev")
> > Signed-off-by: Tomasz Duszynski <tomasz.duszynski@octakon.com>
> > Acked-by: Alexandru Ardelean <ardeleanalex@gmail.com>
>
> There are a bunch of unused local variables as a result of this change
> (build warnings on my standard W=1 C=1 test). I've dropped those as well and
> applied this to the fixes-togreg branch of iio.git.
>
Right, thanks for catching this.
> We are a bit unfortunate on timing for this as I won't send a pull request
> for fixes until towards the end of the merge window. I've marked it for stable
> though so it should filter back fairly quickly so kernels people actually
> use.
>
> Thanks,
>
> Jonathan
>
> > ---
> > v2:
> > * add fixes tag and ack
> >
> > drivers/iio/industrialio-core.c | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
> > index d92c58a94fe4..98944cfc7331 100644
> > --- a/drivers/iio/industrialio-core.c
> > +++ b/drivers/iio/industrialio-core.c
> > @@ -1939,9 +1939,6 @@ void iio_device_unregister(struct iio_dev *indio_dev)
> >
> > indio_dev->info = NULL;
> >
> > - list_for_each_entry_safe(h, t, &iio_dev_opaque->ioctl_handlers, entry)
> > - list_del(&h->entry);
> > -
> > iio_device_wakeup_eventset(indio_dev);
> > iio_buffer_wakeup_poll(indio_dev);
> >
> > --
> > 2.31.1
> >
>
prev parent reply other threads:[~2021-04-24 12:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 8:02 [PATCH v2] iio: core: fix ioctl handlers removal Tomasz Duszynski
2021-04-24 10:52 ` Jonathan Cameron
2021-04-24 12:09 ` Tomasz Duszynski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIQKgLtdUlSHsJXu@arch \
--to=tomasz.duszynski@octakon.com \
--cc=ardeleanalex@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).