From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: zhuguangqing83@gmail.com, Bastien Nocera <hadess@hadess.net>,
Henrik Rydberg <rydberg@bitmath.org>,
linux-input@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Input: goodix - Fix missing IRQF_ONESHOT as only threaded handler
Date: Sat, 24 Apr 2021 22:30:29 -0700 [thread overview]
Message-ID: <YIT+da7/ZXr5Uj33@google.com> (raw)
In-Reply-To: <CAJKOXPeEHRZboCJs+eScjsLDybDzXSaP3jBLkAYiQt_7Ft2nog@mail.gmail.com>
On Fri, Apr 16, 2021 at 10:47:11AM +0200, Krzysztof Kozlowski wrote:
> On Fri, 16 Apr 2021 at 05:18, <zhuguangqing83@gmail.com> wrote:
> >
> > From: Guangqing Zhu <zhuguangqing83@gmail.com>
> >
> > Coccinelle noticed:
> > drivers/input/touchscreen/goodix.c:497:8-33: ERROR: Threaded IRQ with no
> > primary handler requested without IRQF_ONESHOT
> >
> > Signed-off-by: Guangqing Zhu <zhuguangqing83@gmail.com>
> > ---
> > drivers/input/touchscreen/goodix.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
>
>
> Did you test it? There are several patches like this all over the tree
> so it looks like "let's fix everything from Coccinelle" because you
> ignored at least in some of the cases that the handler is not the
> default primary one. I am not saying that the change is bad, but
> rather it looks automated and needs more consideration.
At least the subject is bad because IRQF_ONESHOT is not missing, it is
simply set up elsewhere, the patch itself is a noop. I do not see a
reason to take this.
Thanks.
--
Dmitry
prev parent reply other threads:[~2021-04-25 5:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 3:17 [PATCH] Input: goodix - Fix missing IRQF_ONESHOT as only threaded handler zhuguangqing83
2021-04-16 8:47 ` Krzysztof Kozlowski
2021-04-25 5:30 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIT+da7/ZXr5Uj33@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=hadess@hadess.net \
--cc=krzk@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@bitmath.org \
--cc=zhuguangqing83@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).