From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Andi Kleen <ak@linux.intel.com>, Ian Rogers <irogers@google.com>,
Jin Yao <yao.jin@linux.intel.com>
Subject: Re: [PATCH] perf stat: Use aggregated counts directly
Date: Sun, 25 Apr 2021 17:50:07 +0200 [thread overview]
Message-ID: <YIWPr5LFOAmQ0fg7@krava> (raw)
In-Reply-To: <20210423023833.1430520-1-namhyung@kernel.org>
On Thu, Apr 22, 2021 at 07:38:33PM -0700, Namhyung Kim wrote:
> The ps->res_stats is for repeated runs, so the interval code should
> not touch it. Actually the aggregated counts are available in the
> counter->counts->aggr, so we can (and should) use it directly IMHO.
>
> No functional change intended.
it looks ok, but it should fix the noise output then, right?
Acked-by: Jiri Olsa <jolsa@redhat.com>
thanks,
jirka
>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
> tools/perf/util/stat-display.c | 8 ++++----
> tools/perf/util/stat.c | 12 ------------
> 2 files changed, 4 insertions(+), 16 deletions(-)
>
> diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
> index d3137bc17065..a38fa6527586 100644
> --- a/tools/perf/util/stat-display.c
> +++ b/tools/perf/util/stat-display.c
> @@ -807,11 +807,11 @@ static void counter_aggr_cb(struct perf_stat_config *config __maybe_unused,
> bool first __maybe_unused)
> {
> struct caggr_data *cd = data;
> - struct perf_stat_evsel *ps = counter->stats;
> + struct perf_counts_values *aggr = &counter->counts->aggr;
>
> - cd->avg += avg_stats(&ps->res_stats[0]);
> - cd->avg_enabled += avg_stats(&ps->res_stats[1]);
> - cd->avg_running += avg_stats(&ps->res_stats[2]);
> + cd->avg += aggr->val;
> + cd->avg_enabled += aggr->ena;
> + cd->avg_running += aggr->run;
> }
>
> /*
> diff --git a/tools/perf/util/stat.c b/tools/perf/util/stat.c
> index 2db46b9bebd0..d3ec2624e036 100644
> --- a/tools/perf/util/stat.c
> +++ b/tools/perf/util/stat.c
> @@ -437,18 +437,6 @@ int perf_stat_process_counter(struct perf_stat_config *config,
>
> aggr->val = aggr->ena = aggr->run = 0;
>
> - /*
> - * We calculate counter's data every interval,
> - * and the display code shows ps->res_stats
> - * avg value. We need to zero the stats for
> - * interval mode, otherwise overall avg running
> - * averages will be shown for each interval.
> - */
> - if (config->interval || config->summary) {
> - for (i = 0; i < 3; i++)
> - init_stats(&ps->res_stats[i]);
> - }
> -
> if (counter->per_pkg)
> evsel__zero_per_pkg(counter);
>
> --
> 2.31.1.498.g6c1eba8ee3d-goog
>
next prev parent reply other threads:[~2021-04-25 15:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 2:38 [PATCH] perf stat: Use aggregated counts directly Namhyung Kim
2021-04-25 15:50 ` Jiri Olsa [this message]
2021-04-25 18:00 ` Namhyung Kim
2021-05-03 21:27 ` Namhyung Kim
2021-05-04 12:37 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIWPr5LFOAmQ0fg7@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).