Re: [PATCH v2 2/3] misc: eeprom_93xx46: Add new 93c56 and 93c66 compatible strings

From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
Cc: "Arnd Bergmann" <arnd@arndb.de>,
	"Jonathan Neuschäfer" <j.ne@posteo.net>,
	linux-kernel@vger.kernel.org,
	"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Aswath Govindraju" <a-govindraju@ti.com>,
	"Vadym Kochan" <vadym.kochan@plvision.eu>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/3] misc: eeprom_93xx46: Add new 93c56 and 93c66 compatible strings
Date: Mon, 26 Apr 2021 09:56:06 +0200	[thread overview]
Message-ID: <YIZyFnld4LcR6+Nd@latitude> (raw)
In-Reply-To: <20210424212543.13929-3-linkmauve@linkmauve.fr>

[-- Attachment #1: Type: text/plain, Size: 803 bytes --]

On Sat, Apr 24, 2021 at 11:25:42PM +0200, Emmanuel Gil Peyrot wrote:
> These two devices have respectively 2048 and 4096 bits of storage,
> compared to 1024 for the 93c46.
> 
> Signed-off-by: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
> ---

Reviewed-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>

>  drivers/misc/eeprom/eeprom_93xx46.c | 35 ++++++++++++++++++++++++++---
>  include/linux/eeprom_93xx46.h       |  3 +++
>  2 files changed, 35 insertions(+), 3 deletions(-)

One thing, so it doesn't go unmentioned: There is another driver for
these EEPROMs, drivers/misc/eeprom/eeprom_93cx6.c, but it isn't
stand-alone, it doesn't even have a probe function AFAICT.
In that sense, I agree with the decision to extend this driver instead
of the other one.

Thanks,
Jonathan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]