From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6D0BC43460 for ; Mon, 26 Apr 2021 14:30:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6BECB6101B for ; Mon, 26 Apr 2021 14:30:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233888AbhDZObW (ORCPT ); Mon, 26 Apr 2021 10:31:22 -0400 Received: from msg-1.mailo.com ([213.182.54.11]:60702 "EHLO msg-1.mailo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233884AbhDZObV (ORCPT ); Mon, 26 Apr 2021 10:31:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1619447429; bh=Inbt0Id184HS+3SGiT3lLvjT+nH9YAUuSWJJoO9mhDY=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=GRITIFBS7qBNvRhBKjagHeWEfp4XWGKuEDBxVSAtONY/hGZbTy23i8VwtQl3hzoDL sFePlnm4NLWaiSByVrcYskAfGjk8AEetyCiJ0cv4+hoIN4ms6mDCouPCS+rQSZoT6v Dj/0vtpp62d1OAKmnH8e9gA8tuD4CeA8ILxB1Yko= Received: by b-5.in.mailobj.net [192.168.90.15] with ESMTP via ip-206.mailobj.net [213.182.55.206] Mon, 26 Apr 2021 16:30:29 +0200 (CEST) X-EA-Auth: UsphZN1IEXvgssBLQ4zn+KLQbV+3wb6p+AFcq6FCeKZHKKwEhG+OjvXxBnXXB3REz0dnhkxjtwH4iz8wk7aqWiIlmkkbGp0P Date: Mon, 26 Apr 2021 20:00:22 +0530 From: Deepak R Varma To: Fabio Aiuto Cc: Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND v3 2/6] staging: media: atomisp: balance braces around if...else block Message-ID: References: <71220662c5facd746e56288cc74786c96fa3c5a7.1619199344.git.drv@mailo.com> <20210426095610.GA1418@agape.jhs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210426095610.GA1418@agape.jhs> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 26, 2021 at 11:56:11AM +0200, Fabio Aiuto wrote: > On Sun, Apr 25, 2021 at 02:12:20PM +0530, Deepak R Varma wrote: > > Balance braces around the if else blocks as per the code style guidelines. > > Resolves checkpatch script CHECK / WARNING feedback messages. > > > > Signed-off-by: Deepak R Varma > > --- > > > > Changes since v2: > > - None. > > Changes since v1: > > - None. > > > > drivers/staging/media/atomisp/i2c/atomisp-gc0310.c | 4 ++-- > > drivers/staging/media/atomisp/i2c/atomisp-gc2235.c | 4 ++-- > > drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c | 4 ++-- > > drivers/staging/media/atomisp/i2c/atomisp-ov2680.c | 7 ++++--- > > drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 4 ++-- > > 5 files changed, 12 insertions(+), 11 deletions(-) > > > > diff --git a/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c b/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c > > index 6be3ee1d93a5..d68a2bcc9ae1 100644 > > --- a/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c > > +++ b/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c > > @@ -872,9 +872,9 @@ static int gc0310_s_power(struct v4l2_subdev *sd, int on) > > { > > int ret; > > > > - if (on == 0) > > + if (on == 0) { > > return power_down(sd); > > - else { > > + } else { > > ret = power_up(sd); > > if (!ret) > > return gc0310_init(sd); > > diff --git a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c > > index 6ba4a8adff7c..e722c639b60d 100644 > > --- a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c > > +++ b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c > > @@ -658,9 +658,9 @@ static int gc2235_s_power(struct v4l2_subdev *sd, int on) > > { > > int ret; > > > > - if (on == 0) > > + if (on == 0) { > > ret = power_down(sd); > > - else { > > + } else { > > ret = power_up(sd); > > if (!ret) > > ret = __gc2235_init(sd); > > diff --git a/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c b/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c > > index f5de81132177..465fc4468442 100644 > > --- a/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c > > +++ b/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c > > @@ -568,9 +568,9 @@ static int power_down(struct v4l2_subdev *sd) > > > > static int mt9m114_s_power(struct v4l2_subdev *sd, int power) > > { > > - if (power == 0) > > + if (power == 0) { > > return power_down(sd); > > - else { > > + } else { > > if (power_up(sd)) > > return -EINVAL; > > > > diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c > > index c90730513438..92c52431bd8f 100644 > > --- a/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c > > +++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c > > @@ -461,11 +461,12 @@ static int ov2680_v_flip(struct v4l2_subdev *sd, s32 value) > > ret = ov2680_read_reg(client, 1, OV2680_FLIP_REG, &val); > > if (ret) > > return ret; > > - if (value) { > > + > > + if (value) > > val |= OV2680_FLIP_MIRROR_BIT_ENABLE; > > - } else { > > + else > > val &= ~OV2680_FLIP_MIRROR_BIT_ENABLE; > > - } > > + > > Hi Deepak, > > what you did above is not what is written in the commit message > description about. Here unneeded bracks are removed in both > branches, is not a matter of braces balancing. Okay. I was thinking adding where necessary and removing where not would lead to expected balancing. I will send this as a separate patch in this patch set. Is it okay to add a new patch to the set now? Thank you, deepak. > > thank you, > > fabio > > > ret = ov2680_write_reg(client, 1, > > OV2680_FLIP_REG, val); > > if (ret) > > diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c > > index aec7392fd1de..d046a9804f63 100644 > > --- a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c > > +++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c > > @@ -772,9 +772,9 @@ static int ov2722_s_power(struct v4l2_subdev *sd, int on) > > { > > int ret; > > > > - if (on == 0) > > + if (on == 0) { > > return power_down(sd); > > - else { > > + } else { > > ret = power_up(sd); > > if (!ret) > > return ov2722_init(sd); > > -- > > 2.25.1 > > > > > > > >