From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_RED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05778C43460 for ; Mon, 26 Apr 2021 17:03:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE8DF61026 for ; Mon, 26 Apr 2021 17:03:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235148AbhDZRE1 (ORCPT ); Mon, 26 Apr 2021 13:04:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:46904 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233736AbhDZRE0 (ORCPT ); Mon, 26 Apr 2021 13:04:26 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id AB08C61077; Mon, 26 Apr 2021 17:03:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619456624; bh=8cSf3MkTCS+C8YlyRAEhNhPSXrEVyPLg6iskO89XY0k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GzNikSZlckoJqVVKtyY/YW92nd8CIoMKHkXGPoaAVglxhfh4BbuTSStHSmwMgLH7U J51NW1rQNgLQa+AaRBKfj2z4y7N2L2PeF3lLUDixDgedX9QkMCAiD+ZNXcMkdXW9WM MGdWf3cknIXrA2+XseHNwPcP+Fv4EeS1cAyZLvdI= Date: Mon, 26 Apr 2021 19:03:41 +0200 From: Greg Kroah-Hartman To: Jiri Slaby Cc: linux-kernel@vger.kernel.org, Kangjie Lu , stable Subject: Re: [PATCH 119/190] Revert "tty: mxs-auart: fix a potential NULL pointer dereference" Message-ID: References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> <20210421130105.1226686-120-gregkh@linuxfoundation.org> <1af822a8-2a1b-9110-9832-ba0fe237a1c1@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1af822a8-2a1b-9110-9832-ba0fe237a1c1@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 22, 2021 at 07:03:55AM +0200, Jiri Slaby wrote: > On 21. 04. 21, 14:59, Greg Kroah-Hartman wrote: > > This reverts commit 6734330654dac550f12e932996b868c6d0dcb421. > > > > Commits from @umn.edu addresses have been found to be submitted in "bad > > faith" to try to test the kernel community's ability to review "known > > malicious" changes. The result of these submissions can be found in a > > paper published at the 42nd IEEE Symposium on Security and Privacy > > entitled, "Open Source Insecurity: Stealthily Introducing > > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > > of Minnesota) and Kangjie Lu (University of Minnesota). > > > > Because of this, all submissions from this group must be reverted from > > the kernel tree and will need to be re-reviewed again to determine if > > they actually are a valid fix. Until that work is complete, remove this > > change to ensure that no problems are being introduced into the > > codebase. > > > > Cc: Kangjie Lu > > Cc: stable > > Cc: Greg Kroah-Hartman > > Signed-off-by: Greg Kroah-Hartman > > --- > > drivers/tty/serial/mxs-auart.c | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.c > > index f414d6acad69..edad6ebbdfd5 100644 > > --- a/drivers/tty/serial/mxs-auart.c > > +++ b/drivers/tty/serial/mxs-auart.c > > @@ -1644,10 +1644,6 @@ static int mxs_auart_probe(struct platform_device *pdev) > > s->port.mapbase = r->start; > > s->port.membase = ioremap(r->start, resource_size(r)); > > - if (!s->port.membase) { > > - ret = -ENOMEM; > > - goto out_disable_clks; > > - } > > I don't think this needs to be reverted -- the original fix is correct. > Now dropped, thanks for the review! greg k-h