From: Jiri Olsa <jolsa@redhat.com>
To: Song Liu <song@kernel.org>
Cc: linux-kernel@vger.kernel.org, kernel-team@fb.com,
acme@kernel.org, acme@redhat.com, namhyung@kernel.org,
jolsa@kernel.org, songliubraving@fb.com
Subject: Re: [PATCH v5 5/5] perf-stat: introduce bpf_counter_ops->disable()
Date: Mon, 26 Apr 2021 23:27:34 +0200 [thread overview]
Message-ID: <YIcwRj4WtsZln4SR@krava> (raw)
In-Reply-To: <20210425214333.1090950-6-song@kernel.org>
On Sun, Apr 25, 2021 at 02:43:33PM -0700, Song Liu wrote:
SNIP
> +static inline int bpf_counter__disable(struct evsel *evsel __maybe_unused)
> +{
> + return 0;
> +}
> +
> static inline int bpf_counter__read(struct evsel *evsel __maybe_unused)
> {
> return -EAGAIN;
> diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
> index d29a8a118973c..e71041c890102 100644
> --- a/tools/perf/util/evlist.c
> +++ b/tools/perf/util/evlist.c
> @@ -17,6 +17,7 @@
> #include "evsel.h"
> #include "debug.h"
> #include "units.h"
> +#include "bpf_counter.h"
> #include <internal/lib.h> // page_size
> #include "affinity.h"
> #include "../perf.h"
> @@ -421,6 +422,9 @@ static void __evlist__disable(struct evlist *evlist, char *evsel_name)
> if (affinity__setup(&affinity) < 0)
> return;
>
> + evlist__for_each_entry(evlist, pos)
> + bpf_counter__disable(pos);
I was wondering why you don't check evsel__is_bpf like
for the enable case.. and realized that we don't skip
bpf evsels in __evlist__enable and __evlist__disable
like we do in read_affinity_counters
so I guess there's extra affinity setup and bunch of
wrong ioctls being called?
jirka
> +
> /* Disable 'immediate' events last */
> for (imm = 0; imm <= 1; imm++) {
> evlist__for_each_cpu(evlist, i, cpu) {
> --
> 2.30.2
>
next prev parent reply other threads:[~2021-04-26 21:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-25 21:43 [PATCH v5 0/5] perf util: bpf perf improvements Song Liu
2021-04-25 21:43 ` [PATCH v5 1/5] perf util: move bpf_perf definitions to a libperf header Song Liu
2021-04-25 21:43 ` [PATCH v5 2/5] perf bpf: check perf_attr_map is compatible with the perf binary Song Liu
2021-04-25 21:43 ` [PATCH v5 3/5] perf-stat: introduce config stat.bpf-counter-events Song Liu
2021-04-25 21:43 ` [PATCH v5 4/5] perf-stat: introduce ':b' modifier Song Liu
2021-04-25 21:43 ` [PATCH v5 5/5] perf-stat: introduce bpf_counter_ops->disable() Song Liu
2021-04-26 21:27 ` Jiri Olsa [this message]
2021-04-26 22:18 ` Song Liu
2021-04-27 12:33 ` Jiri Olsa
2021-04-27 19:30 ` Song Liu
2021-04-29 22:40 ` Song Liu
2021-05-03 14:09 ` Jiri Olsa
2021-05-03 15:25 ` Arnaldo Carvalho de Melo
2021-04-27 19:27 ` Arnaldo Carvalho de Melo
2021-04-27 19:42 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIcwRj4WtsZln4SR@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=jolsa@kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=song@kernel.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).