From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BC84C43462 for ; Tue, 27 Apr 2021 16:26:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E496B61182 for ; Tue, 27 Apr 2021 16:26:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234809AbhD0Q1I (ORCPT ); Tue, 27 Apr 2021 12:27:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:53314 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237939AbhD0Q0D (ORCPT ); Tue, 27 Apr 2021 12:26:03 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id ED1F761182; Tue, 27 Apr 2021 16:25:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619540720; bh=dVj+rE/0pybYckf2YJebySw7gD5D3H/YW7IeZID/EZA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=puuu/0x+9xK+yNkQpE2fYPUOCHjPOXm3tSaIAsbcAmnyO1gYrUb2biatY+KNNxo4H PRxm4cKGx8krqnUqswc6QsgEAwgcTc6KQBSfOqswl0feAWU3YZfSa8/ena19FTWlaI ur6J+uihjpUBjZvmx/poYiGDgkaG7bWwYOZHGf1A= Date: Tue, 27 Apr 2021 18:25:18 +0200 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Aditya Pakki , Ben Skeggs Subject: Re: [PATCH 019/190] Revert "drm/nouveau/drm/noveau: fix reference count leak in nouveau_fbcon_open" Message-ID: References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> <20210421130105.1226686-20-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210421130105.1226686-20-gregkh@linuxfoundation.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 21, 2021 at 02:58:14PM +0200, Greg Kroah-Hartman wrote: > This reverts commit bfad51c7633325b5d4b32444efe04329d53297b2. > > Commits from @umn.edu addresses have been found to be submitted in "bad > faith" to try to test the kernel community's ability to review "known > malicious" changes. The result of these submissions can be found in a > paper published at the 42nd IEEE Symposium on Security and Privacy > entitled, "Open Source Insecurity: Stealthily Introducing > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > of Minnesota) and Kangjie Lu (University of Minnesota). > > Because of this, all submissions from this group must be reverted from > the kernel tree and will need to be re-reviewed again to determine if > they actually are a valid fix. Until that work is complete, remove this > change to ensure that no problems are being introduced into the > codebase. > > Cc: Aditya Pakki > Cc: Ben Skeggs > Signed-off-by: Greg Kroah-Hartman > --- > drivers/gpu/drm/nouveau/nouveau_fbcon.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.c b/drivers/gpu/drm/nouveau/nouveau_fbcon.c > index 4fc0fa696461..6f04e7402a76 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_fbcon.c > +++ b/drivers/gpu/drm/nouveau/nouveau_fbcon.c > @@ -189,10 +189,8 @@ nouveau_fbcon_open(struct fb_info *info, int user) > struct nouveau_fbdev *fbcon = info->par; > struct nouveau_drm *drm = nouveau_drm(fbcon->helper.dev); > int ret = pm_runtime_get_sync(drm->dev->dev); > - if (ret < 0 && ret != -EACCES) { > - pm_runtime_put(drm->dev->dev); > + if (ret < 0 && ret != -EACCES) > return ret; > - } > return 0; > } > > -- > 2.31.1 > Looks correct, dropping this. greg k-h