From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26286C433ED for ; Tue, 27 Apr 2021 14:44:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D6A8D613DD for ; Tue, 27 Apr 2021 14:44:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238424AbhD0Opg (ORCPT ); Tue, 27 Apr 2021 10:45:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:52482 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236368AbhD0Ope (ORCPT ); Tue, 27 Apr 2021 10:45:34 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id DFE7B613DE; Tue, 27 Apr 2021 14:44:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619534691; bh=y7xQg7HUcHp/PFyrlJy5tkwrF8u8aIer+/KELjpDzZo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S21Cv9erKuQfMVDjms63ZFmiUL2LSyJaBJJiHLmw1rc+QBuyslFF9dGl5pD0JcjNs 11T963yCL70QNjYm9u3TnYxrQ/MdJYETBhzW0wwQh+PNbnVxualKzaI55Bxnh3c5Bq CQPZuaPomdEp6DNn6ocAGZqSbjS2I0fTbO88pAFE= Date: Tue, 27 Apr 2021 16:44:48 +0200 From: Greg Kroah-Hartman To: Willy Tarreau Cc: linux-kernel@vger.kernel.org, Kangjie Lu , Alexandre Belloni Subject: Re: [PATCH 142/190] Revert "rtc: hym8563: fix a missing check of block data read" Message-ID: References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> <20210421130105.1226686-143-gregkh@linuxfoundation.org> <20210421142831.GB6631@1wt.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210421142831.GB6631@1wt.eu> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 21, 2021 at 04:28:31PM +0200, Willy Tarreau wrote: > On Wed, Apr 21, 2021 at 03:00:17PM +0200, Greg Kroah-Hartman wrote: > > This reverts commit 9a20b5e35a536d6bb4b2d4a3b14a0457e205356c. > > > > Commits from @umn.edu addresses have been found to be submitted in "bad > > faith" to try to test the kernel community's ability to review "known > > malicious" changes. The result of these submissions can be found in a > > paper published at the 42nd IEEE Symposium on Security and Privacy > > entitled, "Open Source Insecurity: Stealthily Introducing > > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > > of Minnesota) and Kangjie Lu (University of Minnesota). > > > > Because of this, all submissions from this group must be reverted from > > the kernel tree and will need to be re-reviewed again to determine if > > they actually are a valid fix. Until that work is complete, remove this > > change to ensure that no problems are being introduced into the > > codebase. > > > > Cc: Kangjie Lu > > Cc: Alexandre Belloni > > Signed-off-by: Greg Kroah-Hartman > > --- > > drivers/rtc/rtc-hym8563.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/rtc/rtc-hym8563.c b/drivers/rtc/rtc-hym8563.c > > index 0751cae27285..a9d033eff61e 100644 > > --- a/drivers/rtc/rtc-hym8563.c > > +++ b/drivers/rtc/rtc-hym8563.c > > @@ -94,8 +94,6 @@ static int hym8563_rtc_read_time(struct device *dev, struct rtc_time *tm) > > int ret; > > > > ret = i2c_smbus_read_i2c_block_data(client, HYM8563_SEC, 7, buf); > > - if (ret < 0) > > - return ret; > > > > if (buf[0] & HYM8563_SEC_VL) { > > dev_warn(&client->dev, > > Seems like this one was a valid fix, and that the description matched > what was done; plenty of other drivers also proceed similarly. I suspect > it should be kept. Thanks for the review, I'll drop this revert from my tree. greg k-h