From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56A58C433ED for ; Tue, 27 Apr 2021 14:45:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1C0E561076 for ; Tue, 27 Apr 2021 14:45:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238452AbhD0OqG (ORCPT ); Tue, 27 Apr 2021 10:46:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:52844 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236368AbhD0OqE (ORCPT ); Tue, 27 Apr 2021 10:46:04 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1F609613DD; Tue, 27 Apr 2021 14:45:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619534721; bh=lZM4EtBHLmrz5KIcQm+hfhduJ8ZI0sLaAJW1zVaxXMU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SBFH8O9vWYgoGZCDohMRZ5RiDgAGeqXQl/aFbA8aYi88pL1sQuCaC97k6fGeJ7ALx yV8p87GPdVI1ZJi2i7jbm1dHEalQ0vG5ZwuyGycEhfl11hoQg+bJ7HbpWPxEsA4rdG P6f34Cq/JCyImWG28aCelPkud05uFlapMqZZZ0LQ= Date: Tue, 27 Apr 2021 16:45:19 +0200 From: Greg Kroah-Hartman To: Jiri Kosina Cc: linux-kernel@vger.kernel.org, Kangjie Lu Subject: Re: [PATCH 122/190] Revert "HID: logitech: check the return value of create_singlethread_workqueue" Message-ID: References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> <20210421130105.1226686-123-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 21, 2021 at 05:20:45PM +0200, Jiri Kosina wrote: > On Wed, 21 Apr 2021, Greg Kroah-Hartman wrote: > > > This reverts commit 6c44b15e1c9076d925d5236ddadf1318b0a25ce2. > > > > Commits from @umn.edu addresses have been found to be submitted in "bad > > faith" to try to test the kernel community's ability to review "known > > malicious" changes. The result of these submissions can be found in a > > paper published at the 42nd IEEE Symposium on Security and Privacy > > entitled, "Open Source Insecurity: Stealthily Introducing > > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > > of Minnesota) and Kangjie Lu (University of Minnesota). > > > > Because of this, all submissions from this group must be reverted from > > the kernel tree and will need to be re-reviewed again to determine if > > they actually are a valid fix. Until that work is complete, remove this > > change to ensure that no problems are being introduced into the > > codebase. > > > > Cc: Kangjie Lu > > Cc: Jiri Kosina > > Signed-off-by: Greg Kroah-Hartman > > This particular one doesn't have to be reverted, I have reviewed it again > and it does fix an actual bug. Thanks, I will drop the revert from my tree. greg k-h