From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F8B1C433B4 for ; Tue, 27 Apr 2021 15:00:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D971D61131 for ; Tue, 27 Apr 2021 15:00:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238473AbhD0PBc (ORCPT ); Tue, 27 Apr 2021 11:01:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:35484 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236534AbhD0PB0 (ORCPT ); Tue, 27 Apr 2021 11:01:26 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 26DF261131; Tue, 27 Apr 2021 15:00:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619535641; bh=bZSDzIrPnzA88AECriBmOcbuFWjzIAAagpJSP19FlSM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tDFj5qfvg/9wVwukdmeHn5UQU/CW+i0Si8WSQyGAB7TKpadEhbwqo6S72APC6w+nq 5ITXqOev0/OM0H4Vjm3L5ZaRU45bZrnj5p1KOMM71gX0tuGYkDoSXRnYsqRaHu5ezb ATFVLDNlklutTjxNQZToETuCJ7qF/lcHQ3S/Gjik= Date: Tue, 27 Apr 2021 17:00:39 +0200 From: Greg Kroah-Hartman To: Rob Herring Cc: "linux-kernel@vger.kernel.org" , Kangjie Lu , Aditya Pakki , Finn Thain , Bartlomiej Zolnierkiewicz Subject: Re: [PATCH 097/190] Revert "video: imsttfb: fix potential NULL pointer dereferences" Message-ID: References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> <20210421130105.1226686-98-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 21, 2021 at 09:13:29PM -0500, Rob Herring wrote: > On Wed, Apr 21, 2021 at 8:05 AM Greg Kroah-Hartman > wrote: > > > > This reverts commit 1d84353d205a953e2381044953b7fa31c8c9702d. > > > > Commits from @umn.edu addresses have been found to be submitted in "bad > > faith" to try to test the kernel community's ability to review "known > > malicious" changes. The result of these submissions can be found in a > > paper published at the 42nd IEEE Symposium on Security and Privacy > > entitled, "Open Source Insecurity: Stealthily Introducing > > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > > of Minnesota) and Kangjie Lu (University of Minnesota). > > > > Because of this, all submissions from this group must be reverted from > > the kernel tree and will need to be re-reviewed again to determine if > > they actually are a valid fix. Until that work is complete, remove this > > change to ensure that no problems are being introduced into the > > codebase. > > > > Cc: Kangjie Lu > > Cc: Aditya Pakki > > Cc: Finn Thain > > Cc: Rob Herring > > Sigh, get_maintainers.pl likes to punish people for treewide clean-ups... > > > Cc: Greg Kroah-Hartman > > Cc: Bartlomiej Zolnierkiewicz > > Signed-off-by: Greg Kroah-Hartman > > --- > > drivers/video/fbdev/imsttfb.c | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/drivers/video/fbdev/imsttfb.c b/drivers/video/fbdev/imsttfb.c > > index 3ac053b88495..e04411701ec8 100644 > > --- a/drivers/video/fbdev/imsttfb.c > > +++ b/drivers/video/fbdev/imsttfb.c > > @@ -1512,11 +1512,6 @@ static int imsttfb_probe(struct pci_dev *pdev, const struct pci_device_id *ent) > > info->fix.smem_start = addr; > > info->screen_base = (__u8 *)ioremap(addr, par->ramdac == IBM ? > > 0x400000 : 0x800000); > > - if (!info->screen_base) { > > - release_mem_region(addr, size); > > - framebuffer_release(info); > > - return -ENOMEM; > > - } > > The original change appears to be valid, but incomplete... > > > info->fix.mmio_start = addr + 0x800000; > > par->dc_regs = ioremap(addr + 0x800000, 0x1000); > > ...because what about cleanup when this ioremap fails. > > > par->cmap_regs_phys = addr + 0x840000; > > Then again, if anyone really cared about this driver and h/w (a > PowerMac era PCI display card), it would not still be using fbdev and > would use devm_* apis. Thanks for the review, I've updated the changelog to reflect this mess :) greg k-h