From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AAFFC433ED for ; Tue, 27 Apr 2021 16:55:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 377E2613EB for ; Tue, 27 Apr 2021 16:55:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236414AbhD0Qz7 (ORCPT ); Tue, 27 Apr 2021 12:55:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:42298 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232670AbhD0Qz4 (ORCPT ); Tue, 27 Apr 2021 12:55:56 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id BA6B4613D8; Tue, 27 Apr 2021 16:55:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619542513; bh=QJ4ApnE3siA4jyyCaddy75BBmZQKOCso9kt104d+AGk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BlZlixP9QbPCnMHYaZfDNNAETdPi26BxWDObzhyiMgWuZP03K45JbJpgl0CTIOTSa DHFBsxxZs9vxVgCW34ri5nhStZr7uXhbT1sTxYQvFj2BY5eqsU7u9Ggz7EdCzbmpop 1zWRf4vi2S+1u4k2DXm3OVsPMp/iI/f7Tw9J7z2Y= Date: Tue, 27 Apr 2021 18:55:10 +0200 From: Greg Kroah-Hartman To: Dmitry Torokhov Cc: linux-kernel@vger.kernel.org, Aditya Pakki Subject: Re: [PATCH 157/190] Revert "Input: ad7879 - add check for read errors in interrupt" Message-ID: References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> <20210421130105.1226686-158-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 21, 2021 at 10:03:33AM -0700, Dmitry Torokhov wrote: > Hi Greg, > > On Wed, Apr 21, 2021 at 03:00:32PM +0200, Greg Kroah-Hartman wrote: > > This reverts commit e85bb0beb6498c0dffe18a2f1f16d575bc175c32. > > > > Commits from @umn.edu addresses have been found to be submitted in "bad > > faith" to try to test the kernel community's ability to review "known > > malicious" changes. The result of these submissions can be found in a > > paper published at the 42nd IEEE Symposium on Security and Privacy > > entitled, "Open Source Insecurity: Stealthily Introducing > > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > > of Minnesota) and Kangjie Lu (University of Minnesota). > > > > Because of this, all submissions from this group must be reverted from > > the kernel tree and will need to be re-reviewed again to determine if > > they actually are a valid fix. Until that work is complete, remove this > > change to ensure that no problems are being introduced into the > > codebase. > > This one looks really OK to me and does not have to be reverted (unless > Aditya will come clean and show the error introduced?). I'll drop this revert, but it isn't usually good to be calling printk() from an irq. thanks, greg k-h