linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
Cc: bkkarthik <bkkarthik@pesu.pes.edu>,
	Anupama K Patil <anupamakpatil123@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	skhan@linuxfoundation.org, gregkh@linuxfoundation.org,
	kernelnewbies@kernelnewbies.org
Subject: Re: [PATCH] drivers: pnp: proc.c: Handle errors while attaching devices
Date: Thu, 29 Apr 2021 10:05:13 +0300	[thread overview]
Message-ID: <YIpaqTHV/zYHrV1z@unreal> (raw)
In-Reply-To: <210271.1619670673@turing-police>

On Thu, Apr 29, 2021 at 12:31:13AM -0400, Valdis Klētnieks wrote:
> On Tue, 27 Apr 2021 07:26:27 +0300, Leon Romanovsky said:
> > On Mon, Apr 26, 2021 at 11:20:32PM +0530, bkkarthik wrote:
> > > These were only intended for a clean-up job, the idea of this function came from how PCI handles procfs.
> > > Maybe those should be changed?
> >
> > Probably, the CONFIG_PROC_FS around pci_proc_*() is not needed too.
> 
> Will that actually build correctly if it's an embedded system or something build with
> CONFIG_PROC_FS=n?  I'd expect that to die a horrid death while linking vmlinx due
> to stuff inside that #ifdef calling symbols only present with PROC_FS=m/y.

We are talking about pci_proc_detach_device() and pci_proc_detach_bus() here.
They will build perfectly without CONFIG_PROC_FS.

Thanks

  reply	other threads:[~2021-04-29  7:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-24 19:43 Anupama K Patil
2021-04-24 20:37 ` Valdis Klētnieks
2021-04-25  1:06 ` Barnabás Pőcze
2021-04-26  5:04 ` Leon Romanovsky
2021-04-26 17:50   ` bkkarthik
2021-04-27  4:26     ` Leon Romanovsky
2021-04-29  4:31       ` Valdis Klētnieks
2021-04-29  7:05         ` Leon Romanovsky [this message]
2021-04-28 12:04     ` Jaroslav Kysela
2021-04-28 12:21       ` Leon Romanovsky
2021-04-28 12:26         ` bkkarthik
2021-04-28 12:30         ` Jaroslav Kysela
2021-04-28 12:37           ` bkkarthik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YIpaqTHV/zYHrV1z@unreal \
    --to=leon@kernel.org \
    --cc=anupamakpatil123@gmail.com \
    --cc=bkkarthik@pesu.pes.edu \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernelnewbies@kernelnewbies.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=rafael.j.wysocki@intel.com \
    --cc=skhan@linuxfoundation.org \
    --cc=valdis.kletnieks@vt.edu \
    --subject='Re: [PATCH] drivers: pnp: proc.c: Handle errors while attaching devices' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox