From: "Theodore Ts'o" <tytso@mit.edu>
To: Pavel Skripkin <paskripkin@gmail.com>
Cc: Vegard Nossum <vegard.nossum@oracle.com>,
akpm@linux-foundation.org, peterz@infradead.org, axboe@kernel.dk,
pmladek@suse.com, adilger.kernel@dilger.ca,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+d9e482e303930fa4f6ff@syzkaller.appspotmail.com
Subject: Re: [PATCH] ext4: fix memory leak in ext4_fill_super
Date: Thu, 29 Apr 2021 23:44:32 -0400 [thread overview]
Message-ID: <YIt9IFY4Xsf5K+eZ@mit.edu> (raw)
In-Reply-To: <20210430010547.38f27e39@gmail.com>
On Fri, Apr 30, 2021 at 01:05:47AM +0300, Pavel Skripkin wrote:
> > out of the thread function. That means hanging struct mmpd_data off
> > the struct ext4_sb_info structure, and then adding a function like
> > this to fs/ext4/mmp.c
> >
> > static void ext4_stop_mmpd(struct ext4_sb_info *sbi)
That should "extern void ...", since it will be called from
fs/ext4/super.c. I had originally was thinking to put this function
in fs/ext4/super.c, but from the perspective of keeping the MMP code
in the same source file, it probably makes sense to keep this function
with the other MMP functions.
> > {
> > if (sbi->s_mmp_tsk) {
> > kthread_stop(sbi->s_mmp_tsk);
> > brelse(sbi->s_mmp_data->bh);
> > kfree(sbi->s_mmp_data);
> > sbi->s_mmp_data = NULL;
> > sbi->s_mmp_tsk = NULL;
> > }
> > }
> >
> > Basically, just move all of the cleanup so it is done after the
> > kthread is stopped, so we don't have to do any fancy error checking.
> > We just do it unconditionally.
Cheers,
- Ted
next prev parent reply other threads:[~2021-04-30 3:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 17:28 [PATCH] ext4: fix memory leak in ext4_fill_super Pavel Skripkin
2021-04-29 10:01 ` Vegard Nossum
2021-04-29 11:08 ` Pavel Skripkin
2021-04-29 11:33 ` Pavel Skripkin
2021-04-29 17:05 ` Theodore Ts'o
2021-04-29 19:20 ` Pavel Skripkin
2021-04-29 20:09 ` Pavel Skripkin
2021-04-29 21:41 ` Theodore Ts'o
2021-04-29 22:05 ` Pavel Skripkin
2021-04-30 3:44 ` Theodore Ts'o [this message]
2021-04-30 18:50 ` [PATCH v2] " Pavel Skripkin
2021-05-17 13:40 ` Pavel Skripkin
2021-05-17 18:34 ` Pavel Skripkin
2021-06-05 12:52 ` [RESEND PATCH " Pavel Skripkin
2021-06-17 1:15 ` [PATCH " Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIt9IFY4Xsf5K+eZ@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paskripkin@gmail.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=syzbot+d9e482e303930fa4f6ff@syzkaller.appspotmail.com \
--cc=vegard.nossum@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).