From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E672CC433ED for ; Fri, 30 Apr 2021 12:24:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE2BA6141C for ; Fri, 30 Apr 2021 12:24:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231993AbhD3MZW (ORCPT ); Fri, 30 Apr 2021 08:25:22 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:47616 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230208AbhD3MZR (ORCPT ); Fri, 30 Apr 2021 08:25:17 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lcSBs-001oHb-52; Fri, 30 Apr 2021 14:24:16 +0200 Date: Fri, 30 Apr 2021 14:24:16 +0200 From: Andrew Lunn To: DENG Qingfang Cc: David Miller , f.fainelli@gmail.com, hkallweit1@gmail.com, kuba@kernel.org, Landen.Chao@mediatek.com, matthias.bgg@gmail.com, linux@armlinux.org.uk, sean.wang@mediatek.com, vivien.didelot@gmail.com, olteanv@gmail.com, robh+dt@kernel.org, linus.walleij@linaro.org, gregkh@linuxfoundation.org, sergio.paracuellos@gmail.com, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-staging@lists.linux.dev, devicetree@vger.kernel.org, netdev@vger.kernel.org, weijie.gao@mediatek.com, gch981213@gmail.com, opensource@vdorst.com, frank-w@public-files.de, tglx@linutronix.de, maz@kernel.org Subject: Re: [PATCH net-next 0/4] MT7530 interrupt support Message-ID: References: <20210429062130.29403-1-dqfext@gmail.com> <20210429.170815.956010543291313915.davem@davemloft.net> <20210430023839.246447-1-dqfext@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210430023839.246447-1-dqfext@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 30, 2021 at 10:38:39AM +0800, DENG Qingfang wrote: > On Thu, Apr 29, 2021 at 05:08:15PM -0700, David Miller wrote: > > > > Please fix this: > > > > error: the following would cause module name conflict: > > drivers/net/phy/mediatek.ko > > drivers/usb/musb/mediatek.ko > > So I still have to rename the PHY driver.. > Andrew, what is your suggestion? Is mediatek_phy.c okay? mediatek_phy.c gets you into trouble with the generic PHY drivers. Most Ethernet PHY drivers have the model number in the file name. Does the PHY have its own name/numbering, or is it always considered part of the switch? If the PHY has an identity of its own, use that. Otherwise maybe mediatek75xx.c? Andrew