Re: [PATCH v4 5/9] staging: media: atomisp: reformat code comment blocks

From: Deepak R Varma <drv@mailo.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Fabio Aiuto <fabioaiuto83@gmail.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 5/9] staging: media: atomisp: reformat code comment blocks
Date: Fri, 30 Apr 2021 16:45:44 +0530	[thread overview]
Message-ID: <YIvm4M0Gru+RpV5O@dU2104> (raw)
In-Reply-To: <693e054f-6a7b-d9e7-a72a-07d7fa295487@xs4all.nl>

On Fri, Apr 30, 2021 at 12:04:33PM +0200, Hans Verkuil wrote:
> On 29/04/2021 13:49, Deepak R Varma wrote:
> > On Thu, Apr 29, 2021 at 09:06:12AM +0200, Fabio Aiuto wrote:
> >> Hi Deepak,
> > 
> > Hello Fabio :)
> > 
> >>
> >> On Wed, Apr 28, 2021 at 11:38:45PM +0530, Deepak R Varma wrote:
> >>> Reformat code comment blocks according to the coding style guidelines.
> >>> This resolves different checkpatch script WARNINGs around block comments.
> >>>
> >>> Suggested-by: Fabio Aiuto <fabioaiuto83@gmail.com>
> >>> Signed-off-by: Deepak R Varma <drv@mailo.com>
> >>> ---
> >>>
> >>> Changes since v3:
> >>>    - Include additional header files in the clean up
> >>> Changes since v2:
> >>>    - Tag Fabio Auito for the patch suggestion
> >>>
> >>> diff --git a/drivers/staging/media/atomisp/i2c/mt9m114.h b/drivers/staging/media/atomisp/i2c/mt9m114.h
> >>> index 787bbf59e895..aad98f37aaa6 100644
> >>> --- a/drivers/staging/media/atomisp/i2c/mt9m114.h
> >>> +++ b/drivers/staging/media/atomisp/i2c/mt9m114.h
> >>> @@ -765,7 +765,8 @@ static struct misensor_reg const mt9m114_common[] = {
> >>>  	{MISENSOR_16BIT, 0xC868, 0x0280}, /* cam_output_width = 952 */
> >>>  	{MISENSOR_16BIT, 0xC86A, 0x01E0}, /* cam_output_height = 538 */
> >>>  	/* LOAD = Step3-Recommended
> >>> -	 * Patch,Errata and Sensor optimization Setting */
> >>> +	 * Patch,Errata and Sensor optimization Setting
> >>> +	 */
> >>
> >> 	/*
> >> 	 * LOAD = Step3-Recommended
> >>
> >> :(
> > 
> > oops... sorry for the oversight. Not sure how I missed it.
> > I will wait for any other feedback on other patches and send
> > in a corrected version shortly.
> 
> I've fixed this up myself.
> 
> I'm taking this series and make a PR for this, wrapping up these
> atomisp cleanups.
> 
> If you plan any more cleanups, then please do this on top of this
> branch: https://git.linuxtv.org/hverkuil/media_tree.git/log/?h=for-v5.14-out1
> 
> That contains all pending cleanups for staging/media.

Thank you Hans and everyone. Appreciate your time, comments and patience. I
understand this entire patch series is acceptable for your consideration and
that I can now move on to other changes.

I will be sending additional clean up patches and I will base those on top of the
mentioned branch.

Have a good one.
deepak.

> 
> Regards,
> 
> 	Hans
> 
> > 
> > Thank you,
> > deepak.
> > 
> > 
> > 
> >>
> >>
> >>>  	{MISENSOR_16BIT, 0x316A, 0x8270}, /* DAC_TXLO_ROW */
> >>>
> >>
> >> thank you,
> >>
> >> fabio
> > 
> > 
> 