linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Hayes Wang <hayeswang@realtek.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
	syzbot <syzbot+95afd23673f5dd295c57@syzkaller.appspotmail.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"syzkaller-bugs@googlegroups.com"
	<syzkaller-bugs@googlegroups.com>,
	nic_swsd <nic_swsd@realtek.com>
Subject: Re: [syzbot] WARNING in rtl8152_probe
Date: Fri, 14 May 2021 08:48:51 +0200	[thread overview]
Message-ID: <YJ4dU3yCwd2wMq5f@kroah.com> (raw)
In-Reply-To: <bde8fc1229ec41e99ec77f112cc5ee01@realtek.com>

On Fri, May 14, 2021 at 02:58:00AM +0000, Hayes Wang wrote:
> Alan Stern <stern@rowland.harvard.edu>
> > Sent: Thursday, May 13, 2021 10:26 PM
> [...]
> > Syzbot doesn't test real devices.  It tests emulations, and the emulated
> > devices usually behave very strangely and in very peculiar and
> > unexpected ways, so as to trigger bugs in the kernel.  That's why the
> > USB devices you see in syzbot logs usually have bizarre descriptors.
> 
> Do you mean I have to debug for a device which doesn't exist?
> I don't understand why I must consider a fake device
> which provide unexpected USB descriptor deliberately?

Because people can create "bad" devices and plug them into a system
which causes the driver to load and then potentially crash the system or
do other bad things.

USB drivers now need to be able to handle "malicious" devices, it's been
that way for many years now.

thanks,

greg k-h


  parent reply	other threads:[~2021-05-14  6:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-12  9:40 [syzbot] WARNING in rtl8152_probe syzbot
2021-05-13  3:13 ` Hayes Wang
2021-05-13 14:25   ` Alan Stern
2021-05-14  2:58     ` Hayes Wang
2021-05-14  6:41       ` Dan Carpenter
2021-05-14  7:49         ` Hayes Wang
2021-05-14  6:48       ` Greg KH [this message]
2021-05-14  7:50         ` Hayes Wang
2021-05-14  8:26           ` Greg KH
2021-05-14 10:32             ` Hayes Wang
2021-05-14 15:32           ` Alan Stern
2021-05-17  1:01             ` Hayes Wang
2021-05-17 10:00               ` Oliver Neukum
2021-05-17 13:47                 ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YJ4dU3yCwd2wMq5f@kroah.com \
    --to=greg@kroah.com \
    --cc=davem@davemloft.net \
    --cc=hayeswang@realtek.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    --cc=stern@rowland.harvard.edu \
    --cc=syzbot+95afd23673f5dd295c57@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).