From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 271BDC433ED for ; Fri, 14 May 2021 08:10:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E9B1761453 for ; Fri, 14 May 2021 08:10:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233416AbhENILy (ORCPT ); Fri, 14 May 2021 04:11:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:43028 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229654AbhENILx (ORCPT ); Fri, 14 May 2021 04:11:53 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 87A2B61451; Fri, 14 May 2021 08:10:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620979842; bh=ChdJtnXGfwPwSfJqxRHdRCzodI2o/6/gSbEMsLKE7H8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=L9veiuUvhaP+6mRKND1UX0jGh2wR/jgQUXpkc3hrjQ+alC09x2g1oLiuv/tABxsTB pcVq1ky8+df2/VPEGylBL3C0wRpDpVto9V7nXWbWjkTgGXmazvJVTa0TiTCZ1J+apc STV5rYt/u4t0hAsK1g3HxXefO7+mZbJuIUUQHcuFhsDcSqmq2N4FAvsJw3hMDub7wJ IV0R746R0fLJiM/S6yjFa/PjPT+ML2OFzGtD9eSLuMInGEVLdT+KL/nChGzo5Q6PUl /JucOUT95EQ7RrtwuMcyY7bX3arVFz0MTXZVUAQACSUvArEUNe0JSqW87Ps1XIkUep pTIsQhd5rNnjQ== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1lhSuA-0008Uw-74; Fri, 14 May 2021 10:10:42 +0200 Date: Fri, 14 May 2021 10:10:42 +0200 From: Johan Hovold To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Sasha Levin Subject: Re: [PATCH 5.10 245/530] tty: actually undefine superseded ASYNC flags Message-ID: References: <20210512144819.664462530@linuxfoundation.org> <20210512144827.885941093@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 14, 2021 at 09:55:01AM +0200, Greg Kroah-Hartman wrote: > On Wed, May 12, 2021 at 05:17:32PM +0200, Johan Hovold wrote: > > On Wed, May 12, 2021 at 04:45:55PM +0200, Greg Kroah-Hartman wrote: > > > From: Johan Hovold > > > > > > [ Upstream commit d09845e98a05850a8094ea8fd6dd09a8e6824fff ] > > > > > > Some kernel-internal ASYNC flags have been superseded by tty-port flags > > > and should no longer be used by kernel drivers. > > > > > > Fix the misspelled "__KERNEL__" compile guards which failed their sole > > > purpose to break out-of-tree drivers that have not yet been updated. > > > > > > Fixes: 5c0517fefc92 ("tty: core: Undefine ASYNC_* flags superceded by TTY_PORT* flags") > > > Signed-off-by: Johan Hovold > > > Link: https://lore.kernel.org/r/20210407095208.31838-2-johan@kernel.org > > > Signed-off-by: Greg Kroah-Hartman > > > Signed-off-by: Sasha Levin > > > > I don't think this should be backported to any stable tree and the > > stable tag was left out on purpose. > > It's about time that userspace gets this right, so this should be fine > as it's something that any out-of-tree code is going to have to get > correct eventually. Eventually, yes. Just doesn't seem right to break stuff on purpose in a minor stable update. That said, I really don't care one bit about out-of-tree drivers so go ahead if you want to. Johan