From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AF03C433B4 for ; Fri, 14 May 2021 13:13:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 23CB761406 for ; Fri, 14 May 2021 13:13:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232277AbhENNOt (ORCPT ); Fri, 14 May 2021 09:14:49 -0400 Received: from mga14.intel.com ([192.55.52.115]:48750 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232217AbhENNOs (ORCPT ); Fri, 14 May 2021 09:14:48 -0400 IronPort-SDR: NQSmRFaHJxAXGGHu9X1BhVkN8n3ZwIU/WwUz6HVRtf7gtR0+i5nYYo83Vqnr/S+YUGIWa+NF9f NDfO21nCImFA== X-IronPort-AV: E=McAfee;i="6200,9189,9983"; a="199865020" X-IronPort-AV: E=Sophos;i="5.82,299,1613462400"; d="scan'208";a="199865020" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2021 06:13:32 -0700 IronPort-SDR: 74l511Rb9o5gDukdPDL6bOeNbq6KgQcj3lP8iDQqaTWrXmxK5XUlenpjvEJBgSBvCJ8LpyEenR NV3AelhCj7QA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,299,1613462400"; d="scan'208";a="538806639" Received: from kuha.fi.intel.com ([10.237.72.162]) by fmsmga001.fm.intel.com with SMTP; 14 May 2021 06:13:28 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Fri, 14 May 2021 16:13:28 +0300 Date: Fri, 14 May 2021 16:13:28 +0300 From: Heikki Krogerus To: Lorenzo Pieralisi Cc: Hanjun Guo , Sudeep Holla , "Rafael J. Wysocki" , Jean-Philippe Brucker , Joerg Roedel , Eric Auger , Will Deacon , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ACPI/IORT: Handle device properties with software node API Message-ID: References: <20210511125528.18525-1-heikki.krogerus@linux.intel.com> <20210514103912.GA16131@lpieralisi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210514103912.GA16131@lpieralisi> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 14, 2021 at 11:39:12AM +0100, Lorenzo Pieralisi wrote: > On Tue, May 11, 2021 at 03:55:28PM +0300, Heikki Krogerus wrote: > > The older device property API is going to be removed. > > Replacing the device_add_properties() call with software > > node API equivalent device_create_managed_software_node(). > > > > Fixes: 434b73e61cc6 ("iommu/arm-smmu-v3: Use device properties for pasid-num-bits") > > Is this really fixing anything ? I am not sure I understand what you > would like to achieve with this tag. Right now it's not possible to simply remove the old API because some of the maintainers want to take care of the conversion themselves, but at the same time I also do not want to see any new releases of the kernel that introduce more users for it. That's why it's a fix. > > Signed-off-by: Heikki Krogerus > > --- > > drivers/acpi/arm64/iort.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > With the above comment clarified: > > Acked-by: Lorenzo Pieralisi > > > diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c > > index 3912a1f6058e5..e34937e11186a 100644 > > --- a/drivers/acpi/arm64/iort.c > > +++ b/drivers/acpi/arm64/iort.c > > @@ -976,7 +976,7 @@ static void iort_named_component_init(struct device *dev, > > FIELD_GET(ACPI_IORT_NC_PASID_BITS, > > nc->node_flags)); > > > > - if (device_add_properties(dev, props)) > > + if (device_create_managed_software_node(dev, props, NULL)) > > dev_warn(dev, "Could not add device properties\n"); > > } > > > > -- > > 2.30.2 > > thanks, -- heikki