linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Dongliang Mu <mudongliangabcd@gmail.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	syzbot+636c58f40a86b4a879e7@syzkaller.appspotmail.com
Subject: Re: [PATCH v2] misc/uss720: fix memory leak in uss720_probe
Date: Fri, 14 May 2021 14:36:42 +0200	[thread overview]
Message-ID: <YJ5u2oEjJyF+e0JU@kroah.com> (raw)
In-Reply-To: <20210514123425.6345-1-mudongliangabcd@gmail.com>

On Fri, May 14, 2021 at 08:34:25PM +0800, Dongliang Mu wrote:
> uss720_probe forgets to decrease the refcount of usbdev in uss720_probe.
> Fix this by decreasing the refcount of usbdev by usb_put_dev.
> 
> BUG: memory leak
> unreferenced object 0xffff888101113800 (size 2048):
>   comm "kworker/0:1", pid 7, jiffies 4294956777 (age 28.870s)
>   hex dump (first 32 bytes):
>     ff ff ff ff 31 00 00 00 00 00 00 00 00 00 00 00  ....1...........
>     00 00 00 00 00 00 00 00 00 00 00 00 03 00 00 00  ................
>   backtrace:
>     [<ffffffff82b8e822>] kmalloc include/linux/slab.h:554 [inline]
>     [<ffffffff82b8e822>] kzalloc include/linux/slab.h:684 [inline]
>     [<ffffffff82b8e822>] usb_alloc_dev+0x32/0x450 drivers/usb/core/usb.c:582
>     [<ffffffff82b98441>] hub_port_connect drivers/usb/core/hub.c:5129 [inline]
>     [<ffffffff82b98441>] hub_port_connect_change drivers/usb/core/hub.c:5363 [inline]
>     [<ffffffff82b98441>] port_event drivers/usb/core/hub.c:5509 [inline]
>     [<ffffffff82b98441>] hub_event+0x1171/0x20c0 drivers/usb/core/hub.c:5591
>     [<ffffffff81259229>] process_one_work+0x2c9/0x600 kernel/workqueue.c:2275
>     [<ffffffff81259b19>] worker_thread+0x59/0x5d0 kernel/workqueue.c:2421
>     [<ffffffff81261228>] kthread+0x178/0x1b0 kernel/kthread.c:292
>     [<ffffffff8100227f>] ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:294
> 
> Reported-by: syzbot+636c58f40a86b4a879e7@syzkaller.appspotmail.com
> Fixes: 0f36163d3abe ("usb: fix uss720 schedule with interrupts off")
> Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
> ---
>  drivers/usb/misc/uss720.c | 1 +
>  1 file changed, 1 insertion(+)

What changed from v1?  That always goes below the --- line.

Please fix and send a v3.

thanks,

greg k-h

  reply	other threads:[~2021-05-14 12:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-14 12:34 [PATCH v2] misc/uss720: fix memory leak in uss720_probe Dongliang Mu
2021-05-14 12:36 ` Greg KH [this message]
2021-05-14 12:40   ` 慕冬亮

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YJ5u2oEjJyF+e0JU@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mudongliangabcd@gmail.com \
    --cc=syzbot+636c58f40a86b4a879e7@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).