From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31BB2C43461 for ; Fri, 14 May 2021 16:43:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 12D7F613C3 for ; Fri, 14 May 2021 16:43:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234792AbhENQop (ORCPT ); Fri, 14 May 2021 12:44:45 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:40626 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230431AbhENQol (ORCPT ); Fri, 14 May 2021 12:44:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=a3EKWIis+zR6gQ4DUZ9TNegMci0bPDZjHjVHulVe+gI=; b=mhb66vKQJ/NVPgv4tnTioqdNr7 4sQyoTbl26QQtylNUgnVhcbpDT0hQovK5963TuaszgCPDCi9LtXMyor2zoG+x0pZmEVfL+kScAX+w 1QGU3HdB4Zv7O+LZ87G6dA1SaiiGdC+w9HZL+VXcVYMcd8AvrmwuqukUX8m158MhEXUQ=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1lhauK-004D9H-Ld; Fri, 14 May 2021 18:43:24 +0200 Date: Fri, 14 May 2021 18:43:24 +0200 From: Andrew Lunn To: Ansuel Smith Cc: Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Jakub Kicinski , Rob Herring , Heiner Kallweit , Russell King , "open list:NETWORKING DRIVERS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Subject: Re: [RFC PATCH net-next v5 07/25] net: dsa: qca8k: handle error with qca8k_rmw operation Message-ID: References: <20210511020500.17269-1-ansuelsmth@gmail.com> <20210511020500.17269-8-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210511020500.17269-8-ansuelsmth@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -static u32 > -qca8k_rmw(struct qca8k_priv *priv, u32 reg, u32 mask, u32 val) > +static int > +qca8k_rmw(struct qca8k_priv *priv, u32 reg, u32 mask, u32 write_val) > { > struct mii_bus *bus = priv->bus; > u16 r1, r2, page; > - u32 ret; > + u32 val; > + int ret; > > qca8k_split_addr(reg, &r1, &r2, &page); > > @@ -205,10 +206,15 @@ qca8k_rmw(struct qca8k_priv *priv, u32 reg, u32 mask, u32 val) > if (ret < 0) > goto exit; > > - ret = qca8k_mii_read32(bus, 0x10 | r2, r1); > - ret &= ~mask; > - ret |= val; > - qca8k_mii_write32(bus, 0x10 | r2, r1, ret); > + val = qca8k_mii_read32(bus, 0x10 | r2, r1); > + if (val < 0) { > + ret = val; > + goto exit; > + } > + > + val &= ~mask; > + val |= write_val; > + qca8k_mii_write32(bus, 0x10 | r2, r1, val); Does qca8k_mii_write32() not return an code? Seems like yet another function you could modify. But i suggest you wait, get this patchset merged first. Reviewed-by: Andrew Lunn Andrew