linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Andi Kleen <ak@linux.intel.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
	Jiri Olsa <jolsa@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf record: Set timestamp boundary for AUX area events
Date: Mon, 3 May 2021 16:00:22 -0300	[thread overview]
Message-ID: <YJBIRoRZ9WKvELQc@kernel.org> (raw)
In-Reply-To: <20210503161131.GO4032392@tassilo.jf.intel.com>

Em Mon, May 03, 2021 at 09:11:31AM -0700, Andi Kleen escreveu:
> On Mon, May 03, 2021 at 06:06:38PM +0300, Adrian Hunter wrote:
> > On 3/05/21 5:56 pm, Andi Kleen wrote:
> > > On Mon, May 03, 2021 at 09:42:22AM +0300, Adrian Hunter wrote:
> > >> AUX area data is not processed by 'perf record' and consequently the
> > >>  --timestamp-boundary option may result in no values for "time of first
> > >> sample" and "time of last sample". However there are non-sample events
> > >> that can be used instead, namely 'itrace_start' and 'aux'.
> > 
> > "instead" -> "as well"
> > 
> > >> 'itrace_start' is issued before tracing starts, and 'aux' is issued
> > >> every time data is ready.
> > > 
> > > Hmm, what happens when some other non PT events are in the same perf record?
> > 
> > The sample timestamps are still processed, so the lowest sample timestamp or
> > 'itrace_start' timestamp or 'aux' timestamp is the start.  Similarly for the end.
> > 
> > > And those maybe run at different times than PT (e.g. due to some PT specific
> > > filter).  Does this all work correctly then?
> > 
> > The broadest range is used
> 
> Ok makes sense.
> 
> Acked-by: Andi Kleen <ak@linux.intel.com>

Thanks, applied.

- Arnaldo


      reply	other threads:[~2021-05-03 19:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-03  6:42 [PATCH] perf record: Set timestamp boundary for AUX area events Adrian Hunter
2021-05-03 14:56 ` Andi Kleen
2021-05-03 15:06   ` Adrian Hunter
2021-05-03 16:11     ` Andi Kleen
2021-05-03 19:00       ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YJBIRoRZ9WKvELQc@kernel.org \
    --to=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).