From: Eric Biggers <ebiggers@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: herbert@gondor.apana.org.au, davem@davemloft.net,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [RFC PATCH] crypto: arc4: Implement a version optimized for memory usage
Date: Tue, 4 May 2021 09:57:34 -0700 [thread overview]
Message-ID: <YJF8/oaWUqZsWfOb@gmail.com> (raw)
In-Reply-To: <c52bd8972c9763c3fac685d7c6af3c46a23a1477.1619983555.git.christophe.jaillet@wanadoo.fr>
On Sun, May 02, 2021 at 09:29:46PM +0200, Christophe JAILLET wrote:
> +#if defined(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS)
> +#define S_type u8
> +#else
> +#define S_type u32
> +#endif
> +
> struct arc4_ctx {
> - u32 S[256];
> + S_type S[256];
> u32 x, y;
> };
Is it actually useful to keep both versions? It seems we could just use the u8
version everywhere. Note that there aren't actually any unaligned memory
accesses, so choosing the version conditionally on
CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS seems odd. What are you trying to
determine by checking that?
- Eric
next prev parent reply other threads:[~2021-05-04 16:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-02 19:29 [RFC PATCH] crypto: arc4: Implement a version optimized for memory usage Christophe JAILLET
2021-05-04 16:57 ` Eric Biggers [this message]
2021-05-04 17:59 ` Christophe JAILLET
2021-05-04 19:36 ` Eric Biggers
2021-05-05 10:20 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJF8/oaWUqZsWfOb@gmail.com \
--to=ebiggers@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).