From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D9F0C433B4 for ; Tue, 4 May 2021 20:33:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 370A0613D8 for ; Tue, 4 May 2021 20:33:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232839AbhEDUev (ORCPT ); Tue, 4 May 2021 16:34:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231786AbhEDUet (ORCPT ); Tue, 4 May 2021 16:34:49 -0400 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5C52C06174A for ; Tue, 4 May 2021 13:33:54 -0700 (PDT) Received: by mail-pf1-x42f.google.com with SMTP id h11so398611pfn.0 for ; Tue, 04 May 2021 13:33:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=C/Cj5I1mlYbC1jzOSOOF25th5Igc+hh3GZ0g8FBcqEI=; b=iJK5pVK/mFTAX9dUEyWr8HZrmhDgXZDtAgyBPKUHMH/tfsSqh7lV8WkaqvRkVAayYJ dMIWinGEclPrkiRLO5JznMDfhYa4SPPNcgv3nwymb8py/lcXiUTUqh0JUiobhbBfyUBw gQXwAeCxMotR5IXMRTtcTZF13yvlBcqS1IeFgBTDZ1Hf8zcInRNc7vx1LKBnU3OKgMUW /D6CW0Xdhkg09ACm8LsbGTZHsDR28PW/8DPcEyqiShwOdjIsDZfkO9wSvvvrE3WOCS5N D/XA11bS2yDyGl9Rum8ifYdKmgwhh6iHHSBHmSSeyTa2P8MCaVhgWFhAfPntNpUMwSP/ 9k7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=C/Cj5I1mlYbC1jzOSOOF25th5Igc+hh3GZ0g8FBcqEI=; b=ogSYWujxHtiJUbKfy0tgPjzq3HLYS+ow+Rlml/n9Jj/7Fk5fzucXikFNmJRBXQEeLE JCDOsaG8LIcLYjcw/5EFEqDRipOShKHnTJCaKRSa+bqKvfg3PZnluo5wLhSjvEhSD5Tc Wbxd4QgaIyZQAXYxNbL7gPFMcVkfPUfRsvrzzigqLGYxRZ9UNSonfX32j92kly4H+2JM OFxjAJxodAQSj3XBaHhxNlBbDwxEmz/jEyKtkCW+79EEoKQabw1ZwGoHcnmWDM1m7qs7 9oCu4hazPCDhHd8V1AO+GyPKMaceA4bqh2lPXuN+g2CDEAXYCtnKpzMcb3xofnWMOud6 z0yQ== X-Gm-Message-State: AOAM530n4wn6/aGVKKertCWWT7FdO/KZfEv7zGhbnrKeTRZ09Is1WYus FXG+RPKJtWhLXgfn5CmojNO62A== X-Google-Smtp-Source: ABdhPJwCWZtzZv/BwmPQtdaiVrP1zcRE4DkGiKPJIPVLifXrJtC4yE4WMvk10tD+y6F4JF/C+shn6g== X-Received: by 2002:a17:90b:33c4:: with SMTP id lk4mr7487384pjb.225.1620160434179; Tue, 04 May 2021 13:33:54 -0700 (PDT) Received: from google.com (240.111.247.35.bc.googleusercontent.com. [35.247.111.240]) by smtp.gmail.com with ESMTPSA id k14sm15371273pjg.0.2021.05.04.13.33.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 May 2021 13:33:53 -0700 (PDT) Date: Tue, 4 May 2021 20:33:49 +0000 From: Sean Christopherson To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, srutherford@google.com, joro@8bytes.org, brijesh.singh@amd.com, thomas.lendacky@amd.com, ashish.kalra@amd.com, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Borislav Petkov , x86@kernel.org Subject: Re: [PATCH v3 2/2] KVM: X86: Introduce KVM_HC_PAGE_ENC_STATUS hypercall Message-ID: References: <20210429104707.203055-1-pbonzini@redhat.com> <20210429104707.203055-3-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 04, 2021, Paolo Bonzini wrote: > On 04/05/21 19:09, Sean Christopherson wrote: > > On Sat, May 01, 2021, Paolo Bonzini wrote: > > > - make it completely independent from migration, i.e. it's just a facet of > > > MSR_KVM_PAGE_ENC_STATUS saying whether the bitmap is up-to-date. It would > > > use CPUID bit as the encryption status bitmap and have no code at all in KVM > > > (userspace needs to set up the filter and implement everything). > > > > If the bit is purely a "page encryption status is up-to-date", what about > > overloading KVM_HC_PAGE_ENC_STATUS to handle that status update as well? That > > would eliminate my biggest complaint about having what is effectively a single > > paravirt feature split into two separate, but intertwined chunks of ABI. > > It's true that they are intertwined, but I dislike not having a way to read > the current state. >From the guest?