From: Peter Zijlstra <peterz@infradead.org>
To: "Suthikulpanit, Suravee" <suravee.suthikulpanit@amd.com>
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
iommu@lists.linux-foundation.org, mingo@redhat.com,
joro@8bytes.org, Jon.Grimm@amd.com, amonakov@ispras.ru,
David Coe <david.coe@live.co.uk>
Subject: Re: [PATCH] x86/events/amd/iommu: Fix invalid Perf result due to IOMMU PMC power-gating
Date: Wed, 5 May 2021 15:05:06 +0200 [thread overview]
Message-ID: <YJKYAiC8GiiFPrWk@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <ad67d625-9e59-2216-0f2a-88635a212595@amd.com>
On Wed, May 05, 2021 at 07:39:14PM +0700, Suthikulpanit, Suravee wrote:
> Peter,
>
> On 5/4/2021 7:13 PM, Peter Zijlstra wrote:
> > On Tue, May 04, 2021 at 06:58:29PM +0700, Suthikulpanit, Suravee wrote:
> > > Peter,
> > >
> > > On 5/4/2021 4:39 PM, Peter Zijlstra wrote:
> > > > On Tue, May 04, 2021 at 01:52:36AM -0500, Suravee Suthikulpanit wrote:
> > > >
> > > > > 2. Since AMD IOMMU PMU does not support interrupt mode, the logic
> > > > > can be simplified to always start counting with value zero,
> > > > > and accumulate the counter value when stopping without the need
> > > > > to keep track and reprogram the counter with the previously read
> > > > > counter value.
> > > >
> > > > This relies on the hardware counter being the full 64bit wide, is it?
> > > >
> > >
> > > The HW counter value is 48-bit. Not sure why it needs to be 64-bit?
> > > I might be missing some points here? Could you please describe?
> >
> > How do you deal with the 48bit overflow if you don't use the interrupt?
>
> The IOMMU Perf driver does not currently handle counter overflow since the overflow
> notification mechanism (i.e. IOMMU creates an EVENT_COUNTER_ZERO event in the IOMMU event log,
> and generate an IOMMU MSI interrupt to signal IOMMU driver to process the event.) is not
> currently supported. When counter overflows, the counter becomes zero, and Perf
> reports value zero for the event.
>
> Alternatively, to detect overflow, we might start counting with value 1 so that
> we can detect overflow when the value becomes zero in which case the Perf driver
> could generate error message.
Urgh.. the intel uncore driver programs an hrtimer to periodically fold
deltas. That way the counter will never be short.
next prev parent reply other threads:[~2021-05-05 13:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 6:52 [PATCH] x86/events/amd/iommu: Fix invalid Perf result due to IOMMU PMC power-gating Suravee Suthikulpanit
2021-05-04 9:39 ` Peter Zijlstra
2021-05-04 11:58 ` Suthikulpanit, Suravee
2021-05-04 12:13 ` Peter Zijlstra
2021-05-05 12:39 ` Suthikulpanit, Suravee
2021-05-05 13:05 ` Peter Zijlstra [this message]
2021-05-10 2:08 ` Suthikulpanit, Suravee
2021-05-04 17:04 ` David Coe
2021-05-05 10:24 ` David Coe
2021-05-06 13:48 ` [tip: perf/urgent] " tip-bot2 for Suravee Suthikulpanit
2021-05-14 10:48 ` [PATCH] " David Coe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJKYAiC8GiiFPrWk@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Jon.Grimm@amd.com \
--cc=amonakov@ispras.ru \
--cc=david.coe@live.co.uk \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=suravee.suthikulpanit@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).