From: Vinod Koul <vkoul@kernel.org>
To: quanyang.wang@windriver.com
Cc: Hyun Kwon <hyun.kwon@xilinx.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Michal Simek <michal.simek@xilinx.com>,
Tejas Upadhyay <tejasu@xilinx.com>,
dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [V2][PATCH] dmaengine: xilinx: dpdma: initialize registers before request_irq
Date: Mon, 10 May 2021 21:40:38 +0530 [thread overview]
Message-ID: <YJla/qT1UO1gb/OD@vkoul-mobl.Dlink> (raw)
In-Reply-To: <20210430064041.4058180-1-quanyang.wang@windriver.com>
On 30-04-21, 14:40, quanyang.wang@windriver.com wrote:
> From: Quanyang Wang <quanyang.wang@windriver.com>
>
> In some scenarios (kdump), dpdma hardware irqs has been enabled when
> calling request_irq in probe function, and then the dpdma irq handler
> xilinx_dpdma_irq_handler is invoked to access xdev->chan[i]. But at
> this moment xdev->chan[i] hasn't been initialized.
>
> We should ensure the dpdma controller to be in a consistent and
> clean state before further initialization. So add dpdma_hw_init()
> to do this.
>
> Furthermore, in xilinx_dpdma_disable_irq, disable all interrupts
> instead of error interrupts.
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2021-05-10 16:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 6:40 [V2][PATCH] dmaengine: xilinx: dpdma: initialize registers before request_irq quanyang.wang
2021-05-07 5:34 ` Quanyang Wang
2021-05-10 16:10 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJla/qT1UO1gb/OD@vkoul-mobl.Dlink \
--to=vkoul@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=hyun.kwon@xilinx.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=quanyang.wang@windriver.com \
--cc=tejasu@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).