From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44543C433ED for ; Tue, 11 May 2021 07:29:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 051F661278 for ; Tue, 11 May 2021 07:29:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230443AbhEKHaM (ORCPT ); Tue, 11 May 2021 03:30:12 -0400 Received: from mga14.intel.com ([192.55.52.115]:2345 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230343AbhEKHaJ (ORCPT ); Tue, 11 May 2021 03:30:09 -0400 IronPort-SDR: 2a3sua9LSu5UwqCjj3ECqz0JxdHpWprz7vk3wu+76mZAE3VaVUd8Tf5nNJDeQbQN00E0eMWMIL ukBx0dYAWnHw== X-IronPort-AV: E=McAfee;i="6200,9189,9980"; a="199055536" X-IronPort-AV: E=Sophos;i="5.82,290,1613462400"; d="scan'208";a="199055536" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2021 00:29:02 -0700 IronPort-SDR: C7OJU3FJBXjmJjf42PenthZldjvEx+Zg3fDBLwRehBrErTcGWOYpmfYxyezuSaufd/62hw6QOP TN732OV4sUpw== X-IronPort-AV: E=Sophos;i="5.82,290,1613462400"; d="scan'208";a="392204982" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2021 00:28:54 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lgMp0-00BNQ4-HI; Tue, 11 May 2021 10:28:50 +0300 Date: Tue, 11 May 2021 10:28:50 +0300 From: Andy Shevchenko To: Rikard Falkeborn Cc: Tetsuo Handa , Yury Norov , Linux Kernel Mailing List , Andrew Morton , Rasmus Villemoes , linux-m68k , Linux-Arch , Linux-SH , Alexey Klimov , Arnd Bergmann , David Sterba , Dennis Zhou , Geert Uytterhoeven , Jianpeng Ma , Joe Perches , John Paul Adrian Glaubitz , Josh Poimboeuf , Rich Felker , Stefano Brivio , Wei Yang , Wolfram Sang , Yoshinori Sato Subject: Re: [PATCH 11/12] tools: sync lib/find_bit implementation Message-ID: References: <20210401003153.97325-1-yury.norov@gmail.com> <20210401003153.97325-12-yury.norov@gmail.com> <1ac7bbc2-45d9-26ed-0b33-bf382b8d858b@I-love.SAKURA.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 11, 2021 at 12:51:58AM +0200, Rikard Falkeborn wrote: > On Mon, May 10, 2021 at 06:44:44PM +0300, Andy Shevchenko wrote: ... > Does the following work for you? For simplicity, I copied__is_constexpr from > include/linux/minmax.h (which isn't available in tools/). A proper patch > would reuse __is_constexpr (possibly refactoring it to a separate > header since bits.h including minmax.h for that only seems smelly) I think we need to have it in something like compiler.h (top level). Under 'top level' I meant something with the function as of compiler.h but with Linuxisms rather than compiler attributes or so. Separate header for the (single) macro is too much... > and fix > bits.h in the kernel header as well, to keep the files in sync. Right. -- With Best Regards, Andy Shevchenko