From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A2D3C43460 for ; Tue, 11 May 2021 12:35:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5019C61622 for ; Tue, 11 May 2021 12:35:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231650AbhEKMgO (ORCPT ); Tue, 11 May 2021 08:36:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:41340 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231633AbhEKMgK (ORCPT ); Tue, 11 May 2021 08:36:10 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CED2061628; Tue, 11 May 2021 12:35:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620736503; bh=42NHG5ZV5WD36khbUkUkpaEMxMuvPi6Ex8nEUKHZbpw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EwdgI1JJgIRrBWfqQYYWaAFzM3riRLH1/n8syhNu5zkv2k69OdKwOq6WRX0x3AHjs EVQQPvohYkQO7wnpIDUFhSXmPQ9rf+wadiL6yz1trNP8/ZfHFPZlGBkbjbvsRDsEg4 EIAsj1AQLE0GKC+IfEM+gZBORODGVubWxE5ySIP6w3DWc1HyuSqjy9UPgr0GmUfY8R xAkTihct4xNkqXErqt7IrgxGv9iWBr1YfPE02LauwAyXXK7IQheiFgcgGeKRDPsGcn B0oGCqDvhOPxAoS0oCnLKtdUcox4/OohKAmAfsxUZaDzKe1ODiAQMUs4r7KHO3HM2E W2PJ9NTaudTEg== Date: Tue, 11 May 2021 15:34:59 +0300 From: Leon Romanovsky To: Dennis Dalessandro Cc: Doug Ledford , Jason Gunthorpe , linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, Mike Marciniszyn Subject: Re: [PATCH rdma-next] RDMA/rdmavt: Decouple QP and SGE lists allocations Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 11, 2021 at 08:26:43AM -0400, Dennis Dalessandro wrote: > On 5/11/21 6:36 AM, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > The rdmavt QP has fields that are both needed for the control and data > > path. Such mixed declaration caused to the very specific allocation flow > > with kzalloc_node and SGE list embedded into the struct rvt_qp. > > > > This patch separates QP creation to two: regular memory allocation for > > the control path and specific code for the SGE list, while the access to > > the later is performed through derefenced pointer. > > > > Such pointer and its context are expected to be in the cache, so > > performance difference is expected to be negligible, if any exists. > > > > Signed-off-by: Leon Romanovsky > > --- > > Hi, > > > > This change is needed to convert QP to core allocation scheme. In that > > scheme QP is allocated outside of the driver and size of such allocation > > is constant and can be calculated at the compile time. > > Thanks Leon, we'll get this put through our testing. Thanks a lot. > > -Denny