From: Peter Zijlstra <peterz@infradead.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Lai Jiangshan <laijs@linux.alibaba.com>,
LKML <linux-kernel@vger.kernel.org>,
x86@kernel.org, Joerg Roedel <joro@8bytes.org>,
Borislav Petkov <bp@suse.de>
Subject: Re: [patch 1/2 v2] x86/cpu: Init AP exception handling from cpu_init_secondary()
Date: Wed, 12 May 2021 10:49:59 +0200 [thread overview]
Message-ID: <YJuWt16izc2toXIM@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <87k0o6gtvu.ffs@nanos.tec.linutronix.de>
On Mon, May 10, 2021 at 11:29:25PM +0200, Thomas Gleixner wrote:
> +#ifdef CONFIG_SMP
> +void cpu_init_secondary(void)
> +{
/*
* Relies on the BP having set-up the IDT tables, which
* are loaded on this CPU in the below
* cpu_init_exception_handling().
*/
> + cpu_init_exception_handling();
> + cpu_init();
> +}
> +#endif
Or something along those lines? It took me a little to figure out why
start_secondary() didn't have idt_setup_traps(), hopefully something
like this will avoid a little future confusion.
next prev parent reply other threads:[~2021-05-12 8:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 11:02 [patch 0/2] x86/idt: Consolidate IDT/TSS setup Thomas Gleixner
2021-05-07 11:02 ` [patch 1/2] x86/cpu: Init exception handling from cpu_init_secondary() Thomas Gleixner
2021-05-08 23:40 ` Lai Jiangshan
2021-05-09 13:55 ` Thomas Gleixner
2021-05-10 21:29 ` [patch 1/2 v2] x86/cpu: Init AP " Thomas Gleixner
2021-05-11 9:25 ` Lai Jiangshan
2021-05-12 8:37 ` Peter Zijlstra
2021-05-12 8:49 ` Peter Zijlstra [this message]
2021-05-12 9:52 ` Thomas Gleixner
2021-05-18 12:40 ` [tip: x86/apic] x86_cpu_Init_AP_exception_handling_from_cpu_init_secondary_ tip-bot2 for Borislav Petkov
2021-05-18 12:52 ` [tip: x86/apic] x86/cpu: Init AP exception handling from cpu_init_secondary() tip-bot2 for Borislav Petkov
2021-05-07 11:02 ` [patch 2/2] x86/idt: Rework IDT setup for boot CPU Thomas Gleixner
2021-05-18 12:40 ` [tip: x86/apic] " tip-bot2 for Thomas Gleixner
2021-05-18 12:52 ` tip-bot2 for Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJuWt16izc2toXIM@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bp@suse.de \
--cc=joro@8bytes.org \
--cc=laijs@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).