From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E444CC47089 for ; Thu, 27 May 2021 15:17:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C443B61358 for ; Thu, 27 May 2021 15:17:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235248AbhE0PSg (ORCPT ); Thu, 27 May 2021 11:18:36 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:60308 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234529AbhE0PSd (ORCPT ); Thu, 27 May 2021 11:18:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=sZh68NYV4i6lfMX9rlhUQviE4A3XNjX+lXwtGbnB1bk=; b=ePkEbAEF5tTyzKvVVLSiRUHUfP seI0mnFHZ04IjBbJD/eqtdm7mziyjO4Vp4G0rgoiERCjwI4XGnt5HMQDsG8ZIhec2SMI+A3tyL3Wa 7uaXRpFDVo0N7GOMiSYqbEZDzYPEccywrFmwjm402P0qSsoBt62ewp9aM98gcLPelwSg=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1lmHkf-006ZL4-6P; Thu, 27 May 2021 17:16:49 +0200 Date: Thu, 27 May 2021 17:16:49 +0200 From: Andrew Lunn To: Vladimir Oltean Cc: Oleksij Rempel , Woojung Huh , UNGLinuxDriver@microchip.com, Florian Fainelli , Vivien Didelot , "David S. Miller" , Jakub Kicinski , Michael Grzeschik , kernel@pengutronix.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Russell King Subject: Re: [PATCH net-next v3 1/9] net: phy: micrel: move phy reg offsets to common header Message-ID: References: <20210526043037.9830-1-o.rempel@pengutronix.de> <20210526043037.9830-2-o.rempel@pengutronix.de> <20210526220132.stfahc4mrwfiu6yn@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210526220132.stfahc4mrwfiu6yn@skbuf> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > switch (reg) { > > - case PHY_REG_CTRL: > > + case MII_BMCR: > > ksz_pread8(dev, p, regs[P_NEG_RESTART_CTRL], &restart); > > ksz_pread8(dev, p, regs[P_SPEED_STATUS], &speed); > > ksz_pread8(dev, p, regs[P_FORCE_CTRL], &ctrl); > > if (restart & PORT_PHY_LOOPBACK) > > - data |= PHY_LOOPBACK; > > + data |= BMCR_LOOPBACK; > > if (ctrl & PORT_FORCE_100_MBIT) > > - data |= PHY_SPEED_100MBIT; > > + data |= BMCR_SPEED100; > > if (ksz_is_ksz88x3(dev)) { > > if ((ctrl & PORT_AUTO_NEG_ENABLE)) > > - data |= PHY_AUTO_NEG_ENABLE; > > + data |= BMCR_ANENABLE; > > } else { > > if (!(ctrl & PORT_AUTO_NEG_DISABLE)) > > - data |= PHY_AUTO_NEG_ENABLE; > > + data |= BMCR_ANENABLE; > > } > > if (restart & PORT_POWER_DOWN) > > - data |= PHY_POWER_DOWN; > > + data |= BMCR_PDOWN; > > if (restart & PORT_AUTO_NEG_RESTART) > > - data |= PHY_AUTO_NEG_RESTART; > > + data |= BMCR_ANRESTART; > > if (ctrl & PORT_FORCE_FULL_DUPLEX) > > - data |= PHY_FULL_DUPLEX; > > + data |= BMCR_FULLDPLX; > > if (speed & PORT_HP_MDIX) > > - data |= PHY_HP_MDIX; > > + data |= KSZ886X_BMCR_HP_MDIX; > > if (restart & PORT_FORCE_MDIX) > > - data |= PHY_FORCE_MDIX; > > + data |= KSZ886X_BMCR_FORCE_MDI; > > if (restart & PORT_AUTO_MDIX_DISABLE) > > - data |= PHY_AUTO_MDIX_DISABLE; > > + data |= KSZ886X_BMCR_DISABLE_AUTO_MDIX; > > if (restart & PORT_TX_DISABLE) > > - data |= PHY_TRANSMIT_DISABLE; > > + data |= KSZ886X_BMCR_DISABLE_TRANSMIT; > > if (restart & PORT_LED_OFF) > > - data |= PHY_LED_DISABLE; > > + data |= KSZ886X_BMCR_DISABLE_LED; > > break; > > I am deeply confused as to what this function is doing. It is reading > the 8-bit port registers P_NEG_RESTART_CTRL, P_SPEED_STATUS and > P_FORCE_CTRL and stitching them into a 16-bit "MII_BMCR"? Sort of. Take a look at the datasheet for the ksz8841. It has clause 22 like registers which it exports to a PHY driver. It puts MDIX control into the bottom of the BMCR. So this DSA driver is emulating the ksz8841 so it can share the PHY driver. Andrew