From: Greg KH <gregkh@linuxfoundation.org>
To: Baokun Li <libaokun1@huawei.com>
Cc: ross.schm.dev@gmail.com, fabioaiuto83@gmail.com,
marcocesati@gmail.com, fmdefrancesco@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
weiyongjun1@huawei.com, yuehaibing@huawei.com,
yangjihong1@huawei.com, yukuai3@huawei.com
Subject: Re: [PATCH -next] staging: rtl8723bs: Remove set but not used variable 'reason_code'
Date: Thu, 27 May 2021 14:12:57 +0200 [thread overview]
Message-ID: <YK+Mye9eXudCf6/r@kroah.com> (raw)
In-Reply-To: <20210527120210.321810-1-libaokun1@huawei.com>
On Thu, May 27, 2021 at 08:02:10PM +0800, Baokun Li wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/staging/rtl8723bs/core/rtw_mlme_ext.c: In function 'OnAction_back':
> drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:1729:30: warning:
> variable ‘reason_code’ set but not used [-Wunused-but-set-variable]
>
> It never used since introduction.
>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> index 9fc612fb736f..97b3c2965770 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> @@ -1721,7 +1721,7 @@ unsigned int OnAction_back(struct adapter *padapter, union recv_frame *precv_fra
> struct recv_reorder_ctrl *preorder_ctrl;
> unsigned char *frame_body;
> unsigned char category, action;
> - unsigned short tid, status, reason_code = 0;
> + unsigned short tid, status;
> struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;
> struct mlme_ext_info *pmlmeinfo = &(pmlmeext->mlmext_info);
> u8 *pframe = precv_frame->u.hdr.rx_data;
> @@ -1790,9 +1790,6 @@ unsigned int OnAction_back(struct adapter *padapter, union recv_frame *precv_fra
> ~BIT((frame_body[3] >> 4) & 0xf);
> psta->htpriv.candidate_tid_bitmap &=
> ~BIT((frame_body[3] >> 4) & 0xf);
> -
> - /* reason_code = frame_body[4] | (frame_body[5] << 8); */
> - reason_code = get_unaligned_le16(&frame_body[4]);
> } else if ((frame_body[3] & BIT(3)) == BIT(3)) {
> tid = (frame_body[3] >> 4) & 0x0F;
>
> --
> 2.25.4
>
Does not apply to my tree. Are you _sure_ you are using the latest
version of linux-next?
thanks,
greg k-h
prev parent reply other threads:[~2021-05-27 12:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 12:02 [PATCH -next] staging: rtl8723bs: Remove set but not used variable 'reason_code' Baokun Li
2021-05-27 12:12 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YK+Mye9eXudCf6/r@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=fabioaiuto83@gmail.com \
--cc=fmdefrancesco@gmail.com \
--cc=libaokun1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=marcocesati@gmail.com \
--cc=ross.schm.dev@gmail.com \
--cc=weiyongjun1@huawei.com \
--cc=yangjihong1@huawei.com \
--cc=yuehaibing@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).