linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jessica Yu <jeyu@kernel.org>
To: Yu Kuai <yukuai3@huawei.com>
Cc: linux-kernel@vger.kernel.org, yi.zhang@huawei.com
Subject: Re: [PATCH] module: fix compile error that sect_empty() is not defined in init_build_id()
Date: Thu, 27 May 2021 14:36:00 +0200	[thread overview]
Message-ID: <YK+SMJRDDCZqQJ26@p200300cbcf361a0029e37a38368d6727.dip0.t-ipconnect.de> (raw)
In-Reply-To: <20210527111453.195014-1-yukuai3@huawei.com>

+++ Yu Kuai [27/05/21 19:14 +0800]:
>If 'CONFIG_SYS' is not enabled while 'CONFIG_KALLSYMS' is enabled,
>fix following compile error:
>
>kernel/module.c:2805:8: error: implicit declaration of function ‘sect_empty’;
>did you mean ‘desc_empty’? [-Werror=implicit-function-declaration]
>
>Signed-off-by: Yu Kuai <yukuai3@huawei.com>

Hi,

This has already been fixed in linux-next, see:

     https://lore.kernel.org/r/20210525105049.34804-1-cuibixuan@huawei.com

>---
> kernel/module.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/kernel/module.c b/kernel/module.c
>index decf4601e943..173acb2aecc7 100644
>--- a/kernel/module.c
>+++ b/kernel/module.c
>@@ -2794,7 +2794,8 @@ static void add_kallsyms(struct module *mod, const struct load_info *info)
> }
> #endif /* CONFIG_KALLSYMS */
>
>-#if IS_ENABLED(CONFIG_KALLSYMS) && IS_ENABLED(CONFIG_STACKTRACE_BUILD_ID)
>+#if IS_ENABLED(CONFIG_SYSFS) && IS_ENABLED(CONFIG_KALLSYMS) &&\
>+	IS_ENABLED(CONFIG_STACKTRACE_BUILD_ID)
> static void init_build_id(struct module *mod, const struct load_info *info)
> {
> 	const Elf_Shdr *sechdr;
>-- 
>2.25.4
>

      reply	other threads:[~2021-05-27 12:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-27 11:14 [PATCH] module: fix compile error that sect_empty() is not defined in init_build_id() Yu Kuai
2021-05-27 12:36 ` Jessica Yu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YK+SMJRDDCZqQJ26@p200300cbcf361a0029e37a38368d6727.dip0.t-ipconnect.de \
    --to=jeyu@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yi.zhang@huawei.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).