* [PATCH v2] i2c: I2C_HISI should depend on ACPI
@ 2021-05-04 9:06 Geert Uytterhoeven
2021-05-04 9:17 ` Andy Shevchenko
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2021-05-04 9:06 UTC (permalink / raw)
To: Yicong Yang, Wei Xu, Wolfram Sang
Cc: Andy Shevchenko, Dmitry Osipenko, linux-i2c, linux-arm-kernel,
linux-kernel, Geert Uytterhoeven
The HiSilicon Kunpeng I2C controller driver relies on ACPI to probe for
its presence. Hence add a dependency on ACPI, to prevent asking the
user about this driver when configuring a kernel without ACPI firmware
support.
Fixes: d62fbdb99a85730a ("i2c: add support for HiSilicon I2C controller")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
- Drop dependency on ARCH_HISI, as this is a public IP which doesn't
specifically depend on ARCH_HISI.
---
drivers/i2c/busses/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index b5b4e0d0ff4dd0bc..226c0b79eac030fa 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -647,7 +647,7 @@ config I2C_HIGHLANDER
config I2C_HISI
tristate "HiSilicon I2C controller"
- depends on ARM64 || COMPILE_TEST
+ depends on (ARM64 && ACPI) || COMPILE_TEST
help
Say Y here if you want to have Hisilicon I2C controller support
available on the Kunpeng Server.
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] i2c: I2C_HISI should depend on ACPI
2021-05-04 9:06 [PATCH v2] i2c: I2C_HISI should depend on ACPI Geert Uytterhoeven
@ 2021-05-04 9:17 ` Andy Shevchenko
2021-05-10 13:00 ` Yicong Yang
2021-05-25 19:27 ` Wolfram Sang
2 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2021-05-04 9:17 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Yicong Yang, Wei Xu, Wolfram Sang, Dmitry Osipenko, linux-i2c,
linux-arm-kernel, linux-kernel
On Tue, May 04, 2021 at 11:06:32AM +0200, Geert Uytterhoeven wrote:
> The HiSilicon Kunpeng I2C controller driver relies on ACPI to probe for
> its presence. Hence add a dependency on ACPI, to prevent asking the
> user about this driver when configuring a kernel without ACPI firmware
> support.
As promised, okay from me.
Thanks!
> Fixes: d62fbdb99a85730a ("i2c: add support for HiSilicon I2C controller")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v2:
> - Drop dependency on ARCH_HISI, as this is a public IP which doesn't
> specifically depend on ARCH_HISI.
> ---
> drivers/i2c/busses/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index b5b4e0d0ff4dd0bc..226c0b79eac030fa 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -647,7 +647,7 @@ config I2C_HIGHLANDER
>
> config I2C_HISI
> tristate "HiSilicon I2C controller"
> - depends on ARM64 || COMPILE_TEST
> + depends on (ARM64 && ACPI) || COMPILE_TEST
> help
> Say Y here if you want to have Hisilicon I2C controller support
> available on the Kunpeng Server.
> --
> 2.25.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] i2c: I2C_HISI should depend on ACPI
2021-05-04 9:06 [PATCH v2] i2c: I2C_HISI should depend on ACPI Geert Uytterhoeven
2021-05-04 9:17 ` Andy Shevchenko
@ 2021-05-10 13:00 ` Yicong Yang
2021-05-25 19:27 ` Wolfram Sang
2 siblings, 0 replies; 4+ messages in thread
From: Yicong Yang @ 2021-05-10 13:00 UTC (permalink / raw)
To: Geert Uytterhoeven, Wei Xu, Wolfram Sang
Cc: Andy Shevchenko, Dmitry Osipenko, linux-i2c, linux-arm-kernel,
linux-kernel
On 2021/5/4 17:06, Geert Uytterhoeven wrote:
> The HiSilicon Kunpeng I2C controller driver relies on ACPI to probe for
> its presence. Hence add a dependency on ACPI, to prevent asking the
> user about this driver when configuring a kernel without ACPI firmware
> support.
>
> Fixes: d62fbdb99a85730a ("i2c: add support for HiSilicon I2C controller")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Yicong Yang <yangyicong@hisilicon.com>
> ---
> v2:
> - Drop dependency on ARCH_HISI, as this is a public IP which doesn't
> specifically depend on ARCH_HISI.
> ---
> drivers/i2c/busses/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index b5b4e0d0ff4dd0bc..226c0b79eac030fa 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -647,7 +647,7 @@ config I2C_HIGHLANDER
>
> config I2C_HISI
> tristate "HiSilicon I2C controller"
> - depends on ARM64 || COMPILE_TEST
> + depends on (ARM64 && ACPI) || COMPILE_TEST
> help
> Say Y here if you want to have Hisilicon I2C controller support
> available on the Kunpeng Server.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] i2c: I2C_HISI should depend on ACPI
2021-05-04 9:06 [PATCH v2] i2c: I2C_HISI should depend on ACPI Geert Uytterhoeven
2021-05-04 9:17 ` Andy Shevchenko
2021-05-10 13:00 ` Yicong Yang
@ 2021-05-25 19:27 ` Wolfram Sang
2 siblings, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2021-05-25 19:27 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Yicong Yang, Wei Xu, Andy Shevchenko, Dmitry Osipenko, linux-i2c,
linux-arm-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 483 bytes --]
On Tue, May 04, 2021 at 11:06:32AM +0200, Geert Uytterhoeven wrote:
> The HiSilicon Kunpeng I2C controller driver relies on ACPI to probe for
> its presence. Hence add a dependency on ACPI, to prevent asking the
> user about this driver when configuring a kernel without ACPI firmware
> support.
>
> Fixes: d62fbdb99a85730a ("i2c: add support for HiSilicon I2C controller")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-25 19:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-04 9:06 [PATCH v2] i2c: I2C_HISI should depend on ACPI Geert Uytterhoeven
2021-05-04 9:17 ` Andy Shevchenko
2021-05-10 13:00 ` Yicong Yang
2021-05-25 19:27 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).