From: Wolfram Sang <wsa@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Sean Nyekjaer <sean@geanix.com>,
trix@redhat.com, lars@metafoo.de, andy.shevchenko@gmail.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH] iio: accel: fxls8962af: conditionally compile fxls8962af_i2c_raw_read_errata3()
Date: Tue, 25 May 2021 22:30:52 +0200 [thread overview]
Message-ID: <YK1efL7DMOVZSPuz@kunai> (raw)
In-Reply-To: <20210521175406.274f713b@jic23-huawei>
[-- Attachment #1: Type: text/plain, Size: 781 bytes --]
> > > The build is failing with this link error
> > > ld: fxls8962af-core.o: in function `fxls8962af_fifo_transfer':
> > > fxls8962af-core.c: undefined reference to `i2c_verify_client'
> > >
> > > This is needed for the i2c variant, not the spi variant. So
> > > conditionally compile based on CONFIG_FXLS8962AF_I2C.
> > >
> > Fixes: 68068fad0e1c ("iio: accel: fxls8962af: fix errata bug E3 - I2C burst reads")
> > > Signed-off-by: Tom Rix <trix@redhat.com>
> > Reviewed-by: Sean Nyekjaer <sean@geanix.com>
>
> Given the purpose of that check is to verify it was an i2c_client
> should we be looking to instead provide a stub for the case where
> we don't have CONFIG_I2C?
>
> +CC Wolfram and linux-i2c list for input.
Such a stub sounds reasonable.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-05-25 20:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 23:48 [PATCH] iio: accel: fxls8962af: conditionally compile fxls8962af_i2c_raw_read_errata3() trix
2021-05-19 5:37 ` Sean Nyekjaer
2021-05-21 16:54 ` Jonathan Cameron
2021-05-25 20:30 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YK1efL7DMOVZSPuz@kunai \
--to=wsa@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sean@geanix.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).