From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F506C47088 for ; Wed, 26 May 2021 04:00:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7AAB16142D for ; Wed, 26 May 2021 04:00:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229664AbhEZECZ (ORCPT ); Wed, 26 May 2021 00:02:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229514AbhEZECU (ORCPT ); Wed, 26 May 2021 00:02:20 -0400 Received: from mail-ot1-x32b.google.com (mail-ot1-x32b.google.com [IPv6:2607:f8b0:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB982C061574 for ; Tue, 25 May 2021 21:00:49 -0700 (PDT) Received: by mail-ot1-x32b.google.com with SMTP id i23-20020a9d68d70000b02902dc19ed4c15so30829562oto.0 for ; Tue, 25 May 2021 21:00:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1/0s4irIAHrEsalg1vYZ8qoD26aC19QWgqCayWmosVw=; b=nfyuAbLzS6wleb8opN1gCeIdANOfcVxizXhDbL12q+twpO+KfBaDDqzQbkybbQkHuW fy752HROUtfXiVARGwEt/9jYpplrjGUgXL04OszzgQhKbtktBx1arPwSVhE7F9hRBLyj rtpaq7XKvwrhwEUdm+LcF/tVsnaM8Lea640urg+RmWA9GaSMjqX86CBR/D7AQcdEahRG BmFjbncstNSXWASJbEmlSgBo7JaXA1/bnM+b9UNVYuDeFl3vIxU79Y7dzNbjEnOiV5z9 TTud1wsGlR+h2YLDsORMthKkb9eCG6tIC4KR+1H8Y5Z5ZeRwIHy+5TNmnCqKy40QU7xn 22Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1/0s4irIAHrEsalg1vYZ8qoD26aC19QWgqCayWmosVw=; b=pt5mIQtbx6blZuwuIPqV5V9aC5Ccf2w0ESw6+ao1Wz7EO/WaC4pmyxfys7/z2dY1cf SlLijS78YSCqHb3rRF7m1O6+4fGyXikohLT0YU71Mom+np/qY8eFO4y4KOrzCkLOn1+7 2tliwij0mlDKYc/VlLOD3vuZTSwtJoP/dlkY3eUPzp7SpZMvbgcTHH83cSWlFAZqW/HY RUWk9j7Jfy2xSQaJb5WGuGOzvMnUBbjgQO1D12DzYiTVuwP1B4qVBHckVdEr4RtHZAZQ MgYYsrGD8inrg3D9bC/4ocO2VsdxeDSQPdtJNrccwR7wwMoh5kbf8bxHkPO8FoP9yjy0 O3MA== X-Gm-Message-State: AOAM530JyBzbvYaBYP6iMooykfAwDyg3BGnUmyQ4D6dfvei2acxgQ4uv N6W8T5k/mtMGsweDZLbfoMonpA== X-Google-Smtp-Source: ABdhPJzk1HhgeuWiLDaU1PfKNdSJXCB+4kVlv9S0wuamiLM7l8i7S9GOa6B0UO5B2unyeDujQDsvhA== X-Received: by 2002:a9d:30d2:: with SMTP id r18mr750948otg.170.1622001649055; Tue, 25 May 2021 21:00:49 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id z9sm4248004oti.37.2021.05.25.21.00.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 May 2021 21:00:48 -0700 (PDT) Date: Tue, 25 May 2021 23:00:46 -0500 From: Bjorn Andersson To: Maulik Shah Cc: swboyd@chromium.org, mka@chromium.org, evgreen@chromium.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, agross@kernel.org, dianders@chromium.org, linux@roeck-us.net, rnayak@codeaurora.org, lsrao@codeaurora.org, Mahesh Sivasubramanian , Lina Iyer Subject: Re: [PATCH v7 2/5] soc: qcom: Add SoC sleep stats driver Message-ID: References: <1617704857-19620-1-git-send-email-mkshah@codeaurora.org> <1617704857-19620-3-git-send-email-mkshah@codeaurora.org> <20210412234317.GE1538589@yoga> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 21 May 06:10 CDT 2021, Maulik Shah wrote: > On 4/13/2021 5:13 AM, Bjorn Andersson wrote: > > On Tue 06 Apr 05:27 CDT 2021, Maulik Shah wrote: [..] > > > diff --git a/drivers/soc/qcom/soc_sleep_stats.c b/drivers/soc/qcom/soc_sleep_stats.c [..] > > > +MODULE_SOFTDEP("pre: smem"); > > I believe this should be "qcom_smem", > the module has smem.ko file so "smem" looks proper. > > but given that you call > > qcom_smem_get() in your code you have a hard dependency in place > > already. So, can you help me understand what use this softdep provide? > > If both smem and soc_sleep_stats are compiled as DLKMs, this is to make sure > smem module was loaded first by keeping pre soft dependency. > But we're making a direct function call into the qcom_smem driver, so we already have a hard dependency on qcom_smem.ko being loaded. Regards, Bjorn