linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Mel Gorman <mgorman@techsingularity.net>
Cc: Christoph Hellwig <hch@infradead.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Andrii Nakryiko <andrii.nakryiko@gmail.com>,
	Michal Suchanek <msuchanek@suse.de>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
	Yonghong Song <yhs@fb.com>,
	John Fastabend <john.fastabend@gmail.com>,
	KP Singh <kpsingh@kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	Jiri Olsa <jolsa@kernel.org>, Hritik Vijay <hritikxx8@gmail.com>,
	bpf <bpf@vger.kernel.org>, Linux-Net <netdev@vger.kernel.org>,
	Linux-MM <linux-mm@kvack.org>
Subject: Re: [PATCH] mm/page_alloc: Work around a pahole limitation with zero-sized struct pagesets
Date: Thu, 27 May 2021 10:18:21 +0100	[thread overview]
Message-ID: <YK9j3YeMTZ+0I8NA@infradead.org> (raw)
In-Reply-To: <20210527090422.GA30378@techsingularity.net>

On Thu, May 27, 2021 at 10:04:22AM +0100, Mel Gorman wrote:
> What do you suggest as an alternative?
> 
> I added Arnaldo to the cc as he tagged the last released version of
> pahole (1.21) and may be able to tag a 1.22 with Andrii's fix for pahole
> included.
> 
> The most obvious alternative fix for this issue is to require pahole
> 1.22 to set CONFIG_DEBUG_INFO_BTF but obviously a version 1.22 that works
> needs to exist first and right now it does not. I'd be ok with this but
> users of DEBUG_INFO_BTF may object given that it'll be impossible to set
> the option until there is a release.

Yes, disable BTF.  Empty structs are a very useful feature that we use
in various places in the kernel.  We can't just keep piling hacks over
hacks to make that work with a recent fringe feature.

  reply	other threads:[~2021-05-27  9:19 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-26  8:07 Mel Gorman
2021-05-26  8:16 ` David Hildenbrand
2021-05-26  8:33 ` (BTF) " Michal Suchánek
2021-05-26  9:00   ` Mel Gorman
2021-05-26 17:00   ` Andrii Nakryiko
2021-05-26 17:43     ` Michal Suchánek
2021-05-26 16:57 ` Andrii Nakryiko
2021-05-26 18:13   ` Mel Gorman
2021-05-26 18:41     ` Andrii Nakryiko
2021-05-27  8:04 ` Christoph Hellwig
2021-05-27  9:04   ` Mel Gorman
2021-05-27  9:18     ` Christoph Hellwig [this message]
2021-05-27 14:37       ` Andrii Nakryiko
2021-05-27 14:41         ` Andrii Nakryiko
2021-05-28  8:09           ` David Laight
2021-05-28  9:04             ` Mel Gorman
2021-05-28  9:49               ` David Laight
2021-05-28  9:56                 ` Michal Suchánek
2021-05-28 13:09                   ` David Laight
2021-05-30  0:46             ` Andrii Nakryiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YK9j3YeMTZ+0I8NA@infradead.org \
    --to=hch@infradead.org \
    --cc=acme@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=andrii.nakryiko@gmail.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=hritikxx8@gmail.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kafai@fb.com \
    --cc=kpsingh@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=msuchanek@suse.de \
    --cc=netdev@vger.kernel.org \
    --cc=songliubraving@fb.com \
    --cc=yhs@fb.com \
    --subject='Re: [PATCH] mm/page_alloc: Work around a pahole limitation with zero-sized struct pagesets' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).