From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Leon Romanovsky <leon@kernel.org>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: ALSA: intel8x0: div by zero in snd_intel8x0_update()
Date: Sun, 16 May 2021 19:59:31 +0900 [thread overview]
Message-ID: <YKD7E/VEwE7Dmx3s@google.com> (raw)
In-Reply-To: <s5hbl9b6mah.wl-tiwai@suse.de>
On (21/05/16 11:49), Takashi Iwai wrote:
> Subject: [PATCH] ALSA: intel8x0: Don't update period unless prepared
>
> The interrupt handler of intel8x0 calls snd_intel8x0_update() whenever
> the hardware sets the corresponding status bit for each stream. This
> works fine for most cases as long as the hardware behaves properly.
> But when the hardware gives a wrong bit set, this leads to a NULL
> dereference Oops, and reportedly, this seems what happened on a VM.
>
> For fixing the crash, this patch adds a internal flag indicating that
> the stream is ready to be updated, and check it (as well as the flag
> being in suspended) to ignore such spurious update.
>
> Cc: <stable@vger.kernel.org>
> Reported-by: Sergey Senozhatsky <senozhatsky@chromium.org>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
I kicked the tests. Will let you know.
next prev parent reply other threads:[~2021-05-16 10:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 8:17 ALSA: intel8x0: div by zero in snd_intel8x0_update() Sergey Senozhatsky
2021-05-14 11:05 ` Takashi Iwai
2021-05-14 11:16 ` Sergey Senozhatsky
2021-05-16 8:30 ` Sergey Senozhatsky
2021-05-16 8:31 ` Sergey Senozhatsky
2021-05-16 9:49 ` Takashi Iwai
2021-05-16 10:59 ` Sergey Senozhatsky [this message]
2021-05-16 11:23 ` Sergey Senozhatsky
2021-05-16 12:07 ` Takashi Iwai
2021-05-16 12:55 ` Sergey Senozhatsky
2021-07-06 17:50 ` Max Filippov
2021-07-07 7:02 ` Takashi Iwai
2021-07-07 17:50 ` Max Filippov
2021-07-07 18:14 ` Takashi Iwai
2021-07-07 20:33 ` Max Filippov
2021-07-08 7:13 ` Takashi Iwai
2021-07-08 8:41 ` Max Filippov
2021-07-08 9:00 ` Takashi Iwai
2021-07-08 10:12 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKD7E/VEwE7Dmx3s@google.com \
--to=senozhatsky@chromium.org \
--cc=alsa-devel@alsa-project.org \
--cc=gustavoars@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).