> > > -       debugfs_create_file("call", S_IFREG | S_IRUGO, root, samsung,
> > > +       debugfs_create_file("call", S_IFREG | 0444, root, samsung,
> 
> Actually you may drop IFREG as well as debugfs will add it if there is
> no conflicting file type defined.

Oh, I missed this back then. Quoting only relevant parts of a message
helps me to avoid that ;)

I will add this, to patch 2, though. This is only a plain conversion. v3
coming in a minute.