From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Alexandru Ardelean <aardelean@deviqon.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linus.walleij@linaro.org, bgolaszewski@baylibre.com,
andy@kernel.org
Subject: Re: [PATCH] gpio: gpio-crystalcove: remove platform_set_drvdata() + cleanup probe
Date: Mon, 17 May 2021 10:55:41 +0300 [thread overview]
Message-ID: <YKIhfQg5mV7dQZRC@smile.fi.intel.com> (raw)
In-Reply-To: <20210514093226.22703-1-aardelean@deviqon.com>
On Fri, May 14, 2021 at 12:32:26PM +0300, Alexandru Ardelean wrote:
> The platform_set_drvdata() call is only useful if we need to retrieve back
> the private information.
> Since the driver doesn't do that, it's not useful to have it.
>
> If this is removed, we can also just do a direct return on
> devm_gpiochip_add_data(). We don't need to print that this call failed as
> there are other ways to log/see this during probe.
Pushed to my review and testing queue, thanks!
> Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com>
> ---
> drivers/gpio/gpio-crystalcove.c | 10 +---------
> 1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/drivers/gpio/gpio-crystalcove.c b/drivers/gpio/gpio-crystalcove.c
> index 2ba225720086..5a909f3c79e8 100644
> --- a/drivers/gpio/gpio-crystalcove.c
> +++ b/drivers/gpio/gpio-crystalcove.c
> @@ -339,8 +339,6 @@ static int crystalcove_gpio_probe(struct platform_device *pdev)
> if (!cg)
> return -ENOMEM;
>
> - platform_set_drvdata(pdev, cg);
> -
> mutex_init(&cg->buslock);
> cg->chip.label = KBUILD_MODNAME;
> cg->chip.direction_input = crystalcove_gpio_dir_in;
> @@ -372,13 +370,7 @@ static int crystalcove_gpio_probe(struct platform_device *pdev)
> return retval;
> }
>
> - retval = devm_gpiochip_add_data(&pdev->dev, &cg->chip, cg);
> - if (retval) {
> - dev_warn(&pdev->dev, "add gpio chip error: %d\n", retval);
> - return retval;
> - }
> -
> - return 0;
> + return devm_gpiochip_add_data(&pdev->dev, &cg->chip, cg);
> }
>
> static struct platform_driver crystalcove_gpio_driver = {
> --
> 2.31.1
>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-05-17 7:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 9:32 [PATCH] gpio: gpio-crystalcove: remove platform_set_drvdata() + cleanup probe Alexandru Ardelean
2021-05-17 7:55 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKIhfQg5mV7dQZRC@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=aardelean@deviqon.com \
--cc=andy@kernel.org \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).