From: Borislav Petkov <bp@suse.de>
To: Andrew Halaney <ahalaney@redhat.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH v2] init: Print out unknown kernel parameters
Date: Mon, 17 May 2021 10:23:49 +0200 [thread overview]
Message-ID: <YKIoFcsrILdZSxfp@zn.tnic> (raw)
In-Reply-To: <20210511211009.42259-1-ahalaney@redhat.com>
On Tue, May 11, 2021 at 04:10:09PM -0500, Andrew Halaney wrote:
> It is easy to foobar setting a kernel parameter on the command line
> without realizing it, there's not much output that you can use to
> assess what the kernel did with that parameter by default.
>
> Make it a little more explicit which parameters on the command line
> _looked_ like a valid parameter for the kernel, but did not match
> anything and ultimately got tossed to init. This is very similar to the
> unknown parameter message received when loading a module.
>
> This assumes the parameters are processed in a normal fashion, some
> parameters (dyndbg= for example) don't register their
> parameter with the rest of the kernel's parameters, and therefore
> always show up in this list (and are also given to init - like the
> rest of this list).
>
> Another example is BOOT_IMAGE= is highlighted as an offender, which it
> technically is, but is passed by LILO and GRUB so most systems will see
> that complaint.
>
> An example output where "foobared" and "unrecognized" are intentionally
> invalid parameters:
>
> Kernel command line: BOOT_IMAGE=/boot/vmlinuz-5.12-dirty debug log_buf_len=4M foobared unrecognized=foo
> Unknown command line parameters: foobared BOOT_IMAGE=/boot/vmlinuz-5.12-dirty unrecognized=foo
>
> Suggested-by: Steven Rostedt <rostedt@goodmis.org>
> Suggested-by: Borislav Petkov <bp@suse.de>
> Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
> ---
>
> It's my first time sending a v2 via email, please let me know if I've
> messed that up in anyway. I decided it wasn't worth the effort to do
> "autocorrect" functionality Borislav was pondering about, feel free to
> disagree on that if you have a strong opinion.
Oh well, I guess let's first see how this works in practice.
Looks ok to me:
Acked-by: Borislav Petkov <bp@suse.de>
Thx.
--
Regards/Gruss,
Boris.
SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg
prev parent reply other threads:[~2021-05-17 8:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 21:10 [PATCH v2] init: Print out unknown kernel parameters Andrew Halaney
2021-05-12 23:00 ` Randy Dunlap
2021-05-13 13:00 ` Andrew Halaney
2021-05-13 16:06 ` Randy Dunlap
2021-05-17 8:23 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKIoFcsrILdZSxfp@zn.tnic \
--to=bp@suse.de \
--cc=ahalaney@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).