linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Xiaofei Tan <tanxiaofei@huawei.com>
Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org,
	linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	linuxarm@openeuler.org
Subject: Re: [PATCH 6/9] tty: hvc_console: Fix coding style issues of block comments
Date: Mon, 17 May 2021 16:15:02 +0200	[thread overview]
Message-ID: <YKJ6ZjT8o5xJmBCr@hovoldconsulting.com> (raw)
In-Reply-To: <1621233433-27094-7-git-send-email-tanxiaofei@huawei.com>

On Mon, May 17, 2021 at 02:37:10PM +0800, Xiaofei Tan wrote:
> Fix coding style issues of block comments, reported by checkpatch.pl.
> Besides, add a period at the end of the sentenses.
> 
> Signed-off-by: Xiaofei Tan <tanxiaofei@huawei.com>
> ---
>  drivers/tty/hvc/hvc_console.c | 15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/tty/hvc/hvc_console.c b/drivers/tty/hvc/hvc_console.c
> index 39018e5..a61cdf0 100644
> --- a/drivers/tty/hvc/hvc_console.c
> +++ b/drivers/tty/hvc/hvc_console.c
> @@ -177,7 +177,8 @@ static void hvc_console_print(struct console *co, const char *b,
>  			r = cons_ops[index]->put_chars(vtermnos[index], c, i);
>  			if (r <= 0) {
>  				/* throw away characters on error
> -				 * but spin in case of -EAGAIN */
> +				 * but spin in case of -EAGAIN.
> +				 */

How is this an improvement? First, the multi-line comment style is

	/*
	 * ...
	 */

Second, that sentence is not capitalised so why do add a period?

Third, why are you sending checkpatch.pl cleanups for files outside of
staging?

Unless doing some real changes to the files in question as well this is
mostly just churn and noise that makes it harder to backport fixes and
do code forensics for no real gain.

Greg may disagree, but I don't think we should be encouraging this kind
of patches.

Johan

  reply	other threads:[~2021-05-17 14:34 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-17  6:37 [PATCH 0/9] tty: hvc_console: Fix some coding style issues Xiaofei Tan
2021-05-17  6:37 ` [PATCH 1/9] tty: hvc_console: Fix spaces required around that '=' Xiaofei Tan
2021-05-17  6:37 ` [PATCH 2/9] tty: hvc_console: Fix "foo * bar" should be "foo *bar" Xiaofei Tan
2021-05-17  6:37 ` [PATCH 3/9] tty: hvc_console: Remove trailing whitespace Xiaofei Tan
2021-05-17  6:37 ` [PATCH 4/9] tty: hvc_console: Fix issues of code indent should use tabs Xiaofei Tan
2021-05-17  6:37 ` [PATCH 5/9] tty: hvc_console: Delete spaces prohibited around open parenthesis '(' and ')' Xiaofei Tan
2021-05-17  6:37 ` [PATCH 6/9] tty: hvc_console: Fix coding style issues of block comments Xiaofei Tan
2021-05-17 14:15   ` Johan Hovold [this message]
2021-05-18  4:01     ` Xiaofei Tan
2021-05-20  8:21       ` Johan Hovold
2021-05-20 13:21         ` Xiaofei Tan
2021-05-20 13:52           ` Johan Hovold
2021-05-21  2:23             ` Xiaofei Tan
2021-05-20 15:21         ` Joe Perches
2021-05-21  8:44           ` Johan Hovold
2021-05-17  6:37 ` [PATCH 7/9] tty: hvc_console: Add a blank line after declarations Xiaofei Tan
2021-05-17  6:37 ` [PATCH 8/9] tty: hvc_console: Remove the repeated words 'no' and 'from' Xiaofei Tan
2021-05-17  6:37 ` [PATCH 9/9] tty: hvc_console: Move open brace { on the previous line Xiaofei Tan
2021-05-20 15:11 ` [PATCH 0/9] tty: hvc_console: Fix some coding style issues Greg KH
2021-05-21  2:18   ` Xiaofei Tan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YKJ6ZjT8o5xJmBCr@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@openeuler.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=tanxiaofei@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).