From: Greg KH <gregkh@linuxfoundation.org>
To: Andrew Jeffery <andrew@aj.id.au>
Cc: linux-serial@vger.kernel.org, jirislaby@kernel.org,
joel@jms.id.au, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org,
jenmin_yuan@aspeedtech.com, ryan_chen@aspeedtech.com,
miltonm@us.ibm.com, ChiaWei Wang <chiawei_wang@aspeedtech.com>
Subject: Re: [PATCH] tty: 8250: Add UART_BUG_TXRACE workaround for Aspeed VUART
Date: Mon, 17 May 2021 16:15:04 +0200 [thread overview]
Message-ID: <YKJ6aP/xqAe1hW6A@kroah.com> (raw)
In-Reply-To: <20210517124105.3565860-1-andrew@aj.id.au>
On Mon, May 17, 2021 at 10:11:05PM +0930, Andrew Jeffery wrote:
> Aspeed Virtual UARTs directly bridge e.g. the system console UART on the
> LPC bus to the UART interface on the BMC's internal APB. As such there's
> no RS-232 signalling involved - the UART interfaces on each bus are
> directly connected as the producers and consumers of the one set of
> FIFOs.
>
> The APB in the AST2600 generally runs at 100MHz while the LPC bus peaks
> at 33MHz. The difference in clock speeds exposes a race in the VUART
> design where a Tx data burst on the APB interface can result in a byte
> lost on the LPC interface. The symptom is LSR[DR] remains clear on the
> LPC interface despite data being present in its Rx FIFO, while LSR[THRE]
> remains clear on the APB interface as the host has not consumed the data
> the BMC has transmitted. In this state, the UART has stalled and no
> further data can be transmitted without manual intervention (e.g.
> resetting the FIFOs, resulting in loss of data).
>
> The recommended work-around is to insert a read cycle on the APB
> interface between writes to THR.
>
> Cc: ChiaWei Wang <chiawei_wang@aspeedtech.com>
> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> ---
> drivers/tty/serial/8250/8250.h | 1 +
> drivers/tty/serial/8250/8250_aspeed_vuart.c | 1 +
> drivers/tty/serial/8250/8250_port.c | 2 ++
> 3 files changed, 4 insertions(+)
>
> diff --git a/drivers/tty/serial/8250/8250.h b/drivers/tty/serial/8250/8250.h
> index 52bb21205bb6..4d6f5e0ecd4c 100644
> --- a/drivers/tty/serial/8250/8250.h
> +++ b/drivers/tty/serial/8250/8250.h
> @@ -88,6 +88,7 @@ struct serial8250_config {
> #define UART_BUG_NOMSR (1 << 2) /* UART has buggy MSR status bits (Au1x00) */
> #define UART_BUG_THRE (1 << 3) /* UART has buggy THRE reassertion */
> #define UART_BUG_PARITY (1 << 4) /* UART mishandles parity if FIFO enabled */
> +#define UART_BUG_TXRACE (1 << 5) /* UART Tx fails to set remote DR */
BUG()?
> #ifdef CONFIG_SERIAL_8250_SHARE_IRQ
> diff --git a/drivers/tty/serial/8250/8250_aspeed_vuart.c b/drivers/tty/serial/8250/8250_aspeed_vuart.c
> index a28a394ba32a..4caab8714e2c 100644
> --- a/drivers/tty/serial/8250/8250_aspeed_vuart.c
> +++ b/drivers/tty/serial/8250/8250_aspeed_vuart.c
> @@ -440,6 +440,7 @@ static int aspeed_vuart_probe(struct platform_device *pdev)
> port.port.status = UPSTAT_SYNC_FIFO;
> port.port.dev = &pdev->dev;
> port.port.has_sysrq = IS_ENABLED(CONFIG_SERIAL_8250_CONSOLE);
> + port.bugs |= UART_BUG_TXRACE;
>
> rc = sysfs_create_group(&vuart->dev->kobj, &aspeed_vuart_attr_group);
> if (rc < 0)
> diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c
> index d45dab1ab316..6c032abfc321 100644
> --- a/drivers/tty/serial/8250/8250_port.c
> +++ b/drivers/tty/serial/8250/8250_port.c
> @@ -1809,6 +1809,8 @@ void serial8250_tx_chars(struct uart_8250_port *up)
> count = up->tx_loadsz;
> do {
> serial_out(up, UART_TX, xmit->buf[xmit->tail]);
> + if (up->bugs & UART_BUG_TXRACE)
> + serial_in(up, UART_SCR);
Can you document why you are doing a call here to serial_in(), otherwise
someone running "automated checking scripts" will remove it later as it
seems to be doing nothing.
thanks,
greg k-h
next prev parent reply other threads:[~2021-05-17 16:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 12:41 [PATCH] tty: 8250: Add UART_BUG_TXRACE workaround for Aspeed VUART Andrew Jeffery
2021-05-17 14:15 ` Greg KH [this message]
2021-05-18 1:30 ` Andrew Jeffery
2021-05-18 6:38 ` Greg Kroah-Hartman
2021-05-18 23:39 ` Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKJ6aP/xqAe1hW6A@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andrew@aj.id.au \
--cc=chiawei_wang@aspeedtech.com \
--cc=jenmin_yuan@aspeedtech.com \
--cc=jirislaby@kernel.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=miltonm@us.ibm.com \
--cc=openbmc@lists.ozlabs.org \
--cc=ryan_chen@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).