* [PATCH v1 1/1] drm/i915: Include only needed headers in ascii85.h
@ 2021-04-07 12:23 Andy Shevchenko
2021-04-07 12:46 ` Jani Nikula
2021-05-17 12:19 ` Andy Shevchenko
0 siblings, 2 replies; 6+ messages in thread
From: Andy Shevchenko @ 2021-04-07 12:23 UTC (permalink / raw)
To: Andy Shevchenko, linux-kernel
Cc: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, intel-gfx
The ascii85.h is user of exactly two headers, i.e. math.h and types.h.
There is no need to carry on entire kernel.h.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
include/linux/ascii85.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/linux/ascii85.h b/include/linux/ascii85.h
index 4cc40201273e..83ad775ad0aa 100644
--- a/include/linux/ascii85.h
+++ b/include/linux/ascii85.h
@@ -8,7 +8,8 @@
#ifndef _ASCII85_H_
#define _ASCII85_H_
-#include <linux/kernel.h>
+#include <linux/math.h>
+#include <linux/types.h>
#define ASCII85_BUFSZ 6
--
2.30.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v1 1/1] drm/i915: Include only needed headers in ascii85.h
2021-04-07 12:23 [PATCH v1 1/1] drm/i915: Include only needed headers in ascii85.h Andy Shevchenko
@ 2021-04-07 12:46 ` Jani Nikula
2021-04-07 13:40 ` Andy Shevchenko
2021-05-17 12:19 ` Andy Shevchenko
1 sibling, 1 reply; 6+ messages in thread
From: Jani Nikula @ 2021-04-07 12:46 UTC (permalink / raw)
To: Andy Shevchenko, Andy Shevchenko, linux-kernel
Cc: Joonas Lahtinen, Rodrigo Vivi, intel-gfx
On Wed, 07 Apr 2021, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> The ascii85.h is user of exactly two headers, i.e. math.h and types.h.
> There is no need to carry on entire kernel.h.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
That's hardly drm/i915 specific!
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
But who's going to pick it up and, hopefully, change the subject prefix
to ascii85 or something?
> ---
> include/linux/ascii85.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/ascii85.h b/include/linux/ascii85.h
> index 4cc40201273e..83ad775ad0aa 100644
> --- a/include/linux/ascii85.h
> +++ b/include/linux/ascii85.h
> @@ -8,7 +8,8 @@
> #ifndef _ASCII85_H_
> #define _ASCII85_H_
>
> -#include <linux/kernel.h>
> +#include <linux/math.h>
> +#include <linux/types.h>
>
> #define ASCII85_BUFSZ 6
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 1/1] drm/i915: Include only needed headers in ascii85.h
2021-04-07 12:46 ` Jani Nikula
@ 2021-04-07 13:40 ` Andy Shevchenko
2021-04-07 13:41 ` Andy Shevchenko
0 siblings, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2021-04-07 13:40 UTC (permalink / raw)
To: Jani Nikula; +Cc: linux-kernel, Joonas Lahtinen, Rodrigo Vivi, intel-gfx
On Wed, Apr 07, 2021 at 03:46:37PM +0300, Jani Nikula wrote:
> On Wed, 07 Apr 2021, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > The ascii85.h is user of exactly two headers, i.e. math.h and types.h.
> > There is no need to carry on entire kernel.h.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> That's hardly drm/i915 specific!
It was originated from i915!
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Thanks!
> But who's going to pick it up and, hopefully, change the subject prefix
> to ascii85 or something?
It's drm specific. Should I leave drm and resend? Or what is the general rule
for drm misc changes?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 1/1] drm/i915: Include only needed headers in ascii85.h
2021-04-07 13:40 ` Andy Shevchenko
@ 2021-04-07 13:41 ` Andy Shevchenko
0 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2021-04-07 13:41 UTC (permalink / raw)
To: Jani Nikula; +Cc: linux-kernel, Joonas Lahtinen, Rodrigo Vivi, intel-gfx
On Wed, Apr 07, 2021 at 04:40:10PM +0300, Andy Shevchenko wrote:
> On Wed, Apr 07, 2021 at 03:46:37PM +0300, Jani Nikula wrote:
> > On Wed, 07 Apr 2021, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > > The ascii85.h is user of exactly two headers, i.e. math.h and types.h.
> > > There is no need to carry on entire kernel.h.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >
> > That's hardly drm/i915 specific!
>
> It was originated from i915!
>
> > Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>
> Thanks!
>
> > But who's going to pick it up and, hopefully, change the subject prefix
> > to ascii85 or something?
>
> It's drm specific. Should I leave drm and resend? Or what is the general rule
> for drm misc changes?
Since the topic comes up about drm misc, can somebody approve push access from
me to that?
https://gitlab.freedesktop.org/freedesktop/freedesktop/-/issues/311
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 1/1] drm/i915: Include only needed headers in ascii85.h
2021-04-07 12:23 [PATCH v1 1/1] drm/i915: Include only needed headers in ascii85.h Andy Shevchenko
2021-04-07 12:46 ` Jani Nikula
@ 2021-05-17 12:19 ` Andy Shevchenko
2021-05-17 12:29 ` Christoph Hellwig
1 sibling, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2021-05-17 12:19 UTC (permalink / raw)
To: linux-kernel, Rob Clark, Andrew Morton
Cc: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, intel-gfx
On Wed, Apr 07, 2021 at 03:23:37PM +0300, Andy Shevchenko wrote:
> The ascii85.h is user of exactly two headers, i.e. math.h and types.h.
> There is no need to carry on entire kernel.h.
It seems DRM has strict rules about what's going thru DRM tree and this one,
while being used only for DRM drivers and been originated as i915 code, in a
stale position right now.
Who can take it, please? (It's Rb by Jani)
I Cc'ed this to Andrew, if he is okay to expedite it, and to Rob, who is the
committer of the original move patch.
Personally to me DRM seems the best match, but... see above.
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> include/linux/ascii85.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/ascii85.h b/include/linux/ascii85.h
> index 4cc40201273e..83ad775ad0aa 100644
> --- a/include/linux/ascii85.h
> +++ b/include/linux/ascii85.h
> @@ -8,7 +8,8 @@
> #ifndef _ASCII85_H_
> #define _ASCII85_H_
>
> -#include <linux/kernel.h>
> +#include <linux/math.h>
> +#include <linux/types.h>
>
> #define ASCII85_BUFSZ 6
>
> --
> 2.30.2
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 1/1] drm/i915: Include only needed headers in ascii85.h
2021-05-17 12:19 ` Andy Shevchenko
@ 2021-05-17 12:29 ` Christoph Hellwig
0 siblings, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2021-05-17 12:29 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-kernel, Rob Clark, Andrew Morton, Jani Nikula,
Joonas Lahtinen, Rodrigo Vivi, intel-gfx
Btw, can someone please add a few comments to ascii85.h?
I have no idea WTF "ascii85" is, why it matters and how the two helpers
should be used.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-05-17 12:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-07 12:23 [PATCH v1 1/1] drm/i915: Include only needed headers in ascii85.h Andy Shevchenko
2021-04-07 12:46 ` Jani Nikula
2021-04-07 13:40 ` Andy Shevchenko
2021-04-07 13:41 ` Andy Shevchenko
2021-05-17 12:19 ` Andy Shevchenko
2021-05-17 12:29 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).