From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BE89C43460 for ; Mon, 17 May 2021 13:16:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6464561028 for ; Mon, 17 May 2021 13:16:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235542AbhEQNRV (ORCPT ); Mon, 17 May 2021 09:17:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235470AbhEQNRU (ORCPT ); Mon, 17 May 2021 09:17:20 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDF77C061756 for ; Mon, 17 May 2021 06:16:03 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id l18-20020a1ced120000b029014c1adff1edso5146301wmh.4 for ; Mon, 17 May 2021 06:16:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=rcRjj0kSXaoUG+69UiGMoMFuPjntXCgBD6uppcpvNks=; b=lSTYoAxprm0avW4QjQOozjs5yBsqLn2q/rOyq4ZIh0s/uD1IWHh+lkKBgfXnZL920Z YIZ7pDGa2hn2nT9Z3fm2UPo+EwPk33GO8ecURuxVaf8v9D3vDpstRNXosUzz8WnVTGbo TDIAwRJqXufB+99sKOAcPEx2KUgNQ/HdYNUQ0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=rcRjj0kSXaoUG+69UiGMoMFuPjntXCgBD6uppcpvNks=; b=S1uxUAAai6/a4Mh1R11vZZmDfWdMY2ysHv3t0EI1XjUqPa23QRpNZ36RQWDDhp8N9y df+LcYIECnS6ZaCZzgZJU/YJwiofTrOGj1WaoeB0QYvkjTLSgcSXUSApKQbW2RX4vugi JulFNwB9X5jubZtgoLS3OU6RXq1/yaG6NizvFiuk5VjOwibr7B/yZQLKPfgxcbpSdmW/ 9EsCBg0F0rR6qVjcfwSIFbp2bCGtLgBo4co/E2vYdPgjpRt9iGC8s08/I0VXFq+d3dv1 ayMnk9bmQGC/iRuwAa6E178xE01A850RomBJX/uRKTIwEQUDdkL16MtvNI9+PnT9G0IW H1Kg== X-Gm-Message-State: AOAM531PWzVYXcSxRoKQ5xmjOM1zp7mAiA98m41cOVkzEkAfHIpPLk1x dgaogo8/IhsK0uy+BxOq2LfPvA== X-Google-Smtp-Source: ABdhPJyCiK0AWV7OegSOvUzl9QU2kA5OTz7BASeaDdFo3fnYrQzNotPW2rnw1TP3Oq5TswGW8xQItA== X-Received: by 2002:a7b:cf23:: with SMTP id m3mr8515150wmg.24.1621257362543; Mon, 17 May 2021 06:16:02 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id v3sm9925105wrr.19.2021.05.17.06.16.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 May 2021 06:16:01 -0700 (PDT) Date: Mon, 17 May 2021 15:15:59 +0200 From: Daniel Vetter To: Paul Cercueil Cc: David Airlie , Daniel Vetter , Sam Ravnborg , od@zcrc.me, linux-mips@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] drm/ingenic: Fix pixclock rate for 24-bit serial panels Message-ID: Mail-Followup-To: Paul Cercueil , David Airlie , Sam Ravnborg , od@zcrc.me, linux-mips@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20210323144008.166248-1-paul@crapouillou.net> <6DP1TQ.W6B9JRRW1OY5@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6DP1TQ.W6B9JRRW1OY5@crapouillou.net> X-Operating-System: Linux phenom 5.10.32scarlett+ Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 13, 2021 at 01:29:30PM +0100, Paul Cercueil wrote: > Hi, > > Almost two months later, Since you're committer it's expected that you go actively out to look for review or trade with someone else who has some patches that need a quick look. It will not happen automatically, this is on you. Also generally after 2 weeks the patch is lost and you need to ping it. -Daniel > > > Le mar., mars 23 2021 at 14:40:08 +0000, Paul Cercueil > a écrit : > > When using a 24-bit panel on a 8-bit serial bus, the pixel clock > > requested by the panel has to be multiplied by 3, since the subpixels > > are shifted sequentially. > > > > The code (in ingenic_drm_encoder_atomic_check) already computed > > crtc_state->adjusted_mode->crtc_clock accordingly, but clk_set_rate() > > used crtc_state->adjusted_mode->clock instead. > > > > Fixes: 28ab7d35b6e0 ("drm/ingenic: Properly compute timings when using a > > 3x8-bit panel") > > Cc: stable@vger.kernel.org # v5.10 > > Signed-off-by: Paul Cercueil > > Can I get an ACK for my patch? > > Thanks! > -Paul > > > --- > > drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > > b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > > index d60e1eefc9d1..cba68bf52ec5 100644 > > --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > > +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > > @@ -342,7 +342,7 @@ static void ingenic_drm_crtc_atomic_flush(struct > > drm_crtc *crtc, > > if (priv->update_clk_rate) { > > mutex_lock(&priv->clk_mutex); > > clk_set_rate(priv->pix_clk, > > - crtc_state->adjusted_mode.clock * 1000); > > + crtc_state->adjusted_mode.crtc_clock * 1000); > > priv->update_clk_rate = false; > > mutex_unlock(&priv->clk_mutex); > > } > > -- > > 2.30.2 > > > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch